Skip to content

Port goob factory - #38

Open
Gr-avity wants to merge 13 commits into
ss14-art:masterfrom
Gr-avity:port-goob-factory
Open

Port goob factory#38
Gr-avity wants to merge 13 commits into
ss14-art:masterfrom
Gr-avity:port-goob-factory

Conversation

@Gr-avity

Copy link
Copy Markdown
Collaborator

About the PR

Портировано фактори. Я хз как оно работает - проверяйте сами

Why / Balance

Linked issues

Technical details

Media

Requirements

Fork checklist (hakumai / ss14-art)

  • New fork systems/components/files are in _Art folders, not in upstream files.
  • Every line edited in an upstream file (outside _Art) carries a ss14-art edit marker (single line // ss14-art edit, or block // ss14-art edit start// ss14-art edit end; # ss14-art edit in YAML; <!-- ss14-art edit start -->end in XAML).
  • No edits under RobustToolbox/ (engine — escalated, not edited).
  • Player interactions are predicted (logic in Content.Shared), replicated state is Dirty'd, and entities in network messages/state use NetEntity.
  • Every player-facing string is localized (fork--prefixed keys in Resources/Locale/en-US/_Art/*.ftl, {Loc ...} in XAML, locale keys for entity name/description).
  • Upstream diff is minimal (prefer subscribing from _Art over editing upstream systems).

Breaking changes

Changelog

slarticodefast and others added 13 commits July 27, 2026 04:36
Co-authored-by: deltanedas <@deltanedas:kde.org>
* Initial port of goobstation factorio, missing disposals integration and faxing. Also ports impstations modification for robotic arms to have static power draw. Also adds automation slots to silos and advanced microwave.

* Ports goobstation factorio fax automation, adds to the guidebook entry info about gas canisters.

* Ported Goob Disposals. Removed part about taking
mats out of storage silo cuz it ain't implemented
yet. Seems to work.

* Adds constructor circuitboard to research cuz I
forgor
* add codersprite

* add code for upgrade kits

* add upgrade kits

* add recipes for upgrade kits to industrial engineering

* disable funny recipes

* remove RE

* fuck it make it a warning

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
* why the fuck did a constructor use 6x the energy a lathe needs?

* chore: Automatically update REUSE headers

* chore: Automatically update REUSE headers

---------

Co-authored-by: GoobBot <uristmchands@proton.me>
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 118 files, which is 18 over the limit of 100.

To get a review, narrow the scope:
• coderabbit review --committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 392f9405-bd66-4ad3-bc65-62ec32373a48

📥 Commits

Reviewing files that changed from the base of the PR and between 2abaff7 and a0d3742.

⛔ Files ignored due to path filters (26)
  • Resources/ServerInfo/_Goobstation/Guidebook/Engineering/Automation.xml is excluded by none and included by none
  • Resources/Textures/_DV/Objects/Tools/lathe_upgrade_kit.rsi/icon.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_DV/Objects/Tools/lathe_upgrade_kit.rsi/meta.json is excluded by !**/*.rsi/*.json and included by none
  • Resources/Textures/_Goobstation/Objects/Misc/filter.rsi/icon.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Objects/Misc/filter.rsi/meta.json is excluded by !**/*.rsi/*.json and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/constructor.rsi/icon.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/constructor.rsi/meta.json is excluded by !**/*.rsi/*.json and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/constructor.rsi/powered.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/interactor.rsi/active-powered.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/interactor.rsi/active.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/interactor.rsi/base.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/interactor.rsi/empty-powered.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/interactor.rsi/empty.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/interactor.rsi/icon.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/interactor.rsi/inactive-powered.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/interactor.rsi/inactive.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/interactor.rsi/meta.json is excluded by !**/*.rsi/*.json and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/robotic_arm.rsi/arm-long.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/robotic_arm.rsi/arm-short.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/robotic_arm.rsi/base.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/robotic_arm.rsi/icon.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/robotic_arm.rsi/meta.json is excluded by !**/*.rsi/*.json and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/robotic_arm.rsi/powered.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/storage_bin.rsi/icon.png is excluded by !**/*.png, !**/*.png and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/storage_bin.rsi/meta.json is excluded by !**/*.rsi/*.json and included by none
  • Resources/Textures/_Goobstation/Structures/Machines/storage_bin.rsi/powered.png is excluded by !**/*.png, !**/*.png and included by none
📒 Files selected for processing (118)
  • Content.Client/_Goobstation/Factory/ConstructorSystem.cs
  • Content.Client/_Goobstation/Factory/InteractorSystem.cs
  • Content.Client/_Goobstation/Factory/RoboticArmAnimationSystem.cs
  • Content.Client/_Goobstation/Factory/UI/ConstructorBUI.cs
  • Content.Client/_Goobstation/Factory/UI/LabelFilterBUI.cs
  • Content.Client/_Goobstation/Factory/UI/LabelFilterWindow.xaml
  • Content.Client/_Goobstation/Factory/UI/LabelFilterWindow.xaml.cs
  • Content.Client/_Goobstation/Factory/UI/NameFilterBUI.cs
  • Content.Client/_Goobstation/Factory/UI/NameFilterWindow.xaml
  • Content.Client/_Goobstation/Factory/UI/NameFilterWindow.xaml.cs
  • Content.Client/_Goobstation/Factory/UI/PressureFilterBUI.cs
  • Content.Client/_Goobstation/Factory/UI/PressureFilterWindow.xaml
  • Content.Client/_Goobstation/Factory/UI/PressureFilterWindow.xaml.cs
  • Content.Client/_Goobstation/Factory/UI/StackFilterBUI.cs
  • Content.Client/_Goobstation/Factory/UI/StackFilterWindow.xaml
  • Content.Client/_Goobstation/Factory/UI/StackFilterWindow.xaml.cs
  • Content.Client/_Goobstation/Guidebook/Controls/GuideAutomationSlotsEmbed.cs
  • Content.Server/Construction/ConstructionSystem.Initial.cs
  • Content.Server/Fax/FaxSystem.cs
  • Content.Server/Materials/MaterialStorageSystem.cs
  • Content.Server/Physics/Controllers/ConveyorController.cs
  • Content.Server/_Goobstation/Atmos/EntitySystems/GasCanisterSignalSystem.cs
  • Content.Server/_Goobstation/Construction/FlatpackSignalSystem.cs
  • Content.Server/_Goobstation/Disposals/DisposalSignalSystem.cs
  • Content.Server/_Goobstation/Factory/ConstructorSystem.cs
  • Content.Server/_Goobstation/Factory/Filters/PressureFilterSystem.cs
  • Content.Server/_Goobstation/Factory/InteractorSystem.cs
  • Content.Server/_Goobstation/Fax/FaxSignalSystem.cs
  • Content.Server/_Goobstation/Kitchen/MicrowaveEventsSystem.cs
  • Content.Server/_Goobstation/Singularity/RadCollectorSignalComponent.cs
  • Content.Server/_Goobstation/Singularity/RadCollectorSignalSystem.cs
  • Content.Shared/Containers/ItemSlot/ItemSlotsSystem.cs
  • Content.Shared/DeviceLinking/SharedDeviceLinkSystem.cs
  • Content.Shared/Disposal/Unit/SharedDisposalUnitSystem.cs
  • Content.Shared/DoAfter/DoAfterComponent.cs
  • Content.Shared/DoAfter/SharedDoAfterSystem.cs
  • Content.Shared/Interaction/SharedInteractionSystem.cs
  • Content.Shared/Lathe/LatheComponent.cs
  • Content.Shared/Mobs/Systems/MobThresholdSystem.cs
  • Content.Shared/Stacks/SharedStackSystem.cs
  • Content.Shared/_DV/Construction/UpgradeKitComponent.cs
  • Content.Shared/_DV/Construction/UpgradeKitSystem.cs
  • Content.Shared/_DV/Construction/UpgradedMachineComponent.cs
  • Content.Shared/_DV/Construction/UpgradedMachineSystem.cs
  • Content.Shared/_DV/Lathe/LatheUpgradeComponent.cs
  • Content.Shared/_DV/Lathe/LatheUpgradeSystem.cs
  • Content.Shared/_Goobstation/Construction/ConstructedEvent.cs
  • Content.Shared/_Goobstation/DoAfter/DoAfterEndedEvent.cs
  • Content.Shared/_Goobstation/Factory/AutomatedComponent.cs
  • Content.Shared/_Goobstation/Factory/AutomationSlotsComponent.cs
  • Content.Shared/_Goobstation/Factory/AutomationSystem.cs
  • Content.Shared/_Goobstation/Factory/ConstructorComponent.cs
  • Content.Shared/_Goobstation/Factory/Filters/AutomationFilterComponent.cs
  • Content.Shared/_Goobstation/Factory/Filters/AutomationFilterSystem.cs
  • Content.Shared/_Goobstation/Factory/Filters/CombinedFilterComponent.cs
  • Content.Shared/_Goobstation/Factory/Filters/FilterSlotComponent.cs
  • Content.Shared/_Goobstation/Factory/Filters/LabelFilterComponent.cs
  • Content.Shared/_Goobstation/Factory/Filters/NameFilterComponent.cs
  • Content.Shared/_Goobstation/Factory/Filters/PressureFilterComponent.cs
  • Content.Shared/_Goobstation/Factory/Filters/StackFilterComponent.cs
  • Content.Shared/_Goobstation/Factory/InteractorComponent.cs
  • Content.Shared/_Goobstation/Factory/RoboticArmComponent.cs
  • Content.Shared/_Goobstation/Factory/RoboticArmSystem.cs
  • Content.Shared/_Goobstation/Factory/SharedConstructorSystem.cs
  • Content.Shared/_Goobstation/Factory/SharedInteractorSystem.cs
  • Content.Shared/_Goobstation/Factory/Slots/AutomatedContainer.cs
  • Content.Shared/_Goobstation/Factory/Slots/AutomatedHand.cs
  • Content.Shared/_Goobstation/Factory/Slots/AutomatedItemSlot.cs
  • Content.Shared/_Goobstation/Factory/Slots/AutomatedMaterialStorage.cs
  • Content.Shared/_Goobstation/Factory/Slots/AutomatedPorts.cs
  • Content.Shared/_Goobstation/Factory/Slots/AutomatedStorage.cs
  • Content.Shared/_Goobstation/Factory/Slots/AutomationSlot.cs
  • Content.Shared/_Goobstation/Factory/StartableMachineComponent.cs
  • Content.Shared/_Goobstation/Factory/StartableMachineSystem.cs
  • Content.Shared/_Goobstation/Factory/StorageBinComponent.cs
  • Content.Shared/_Goobstation/Factory/StorageBinSystem.cs
  • Content.Shared/_Shitmed/Autodoc/Components/HandsFillComponent.cs
  • Content.Shared/_Shitmed/Autodoc/Systems/HandsFillSystem.cs
  • Resources/Locale/en-US/_DV/construction/upgrade-kits.ftl
  • Resources/Locale/en-US/_Goobstation/construction/upgrade-kits.ftl
  • Resources/Locale/en-US/_Goobstation/factory/constructor.ftl
  • Resources/Locale/en-US/_Goobstation/factory/filters.ftl
  • Resources/Locale/en-US/_Goobstation/factory/robotic-arm.ftl
  • Resources/Locale/en-US/_Goobstation/guidebook/guides.ftl
  • Resources/Locale/en-US/_Goobstation/machines/automation.ftl
  • Resources/Prototypes/Entities/Structures/Machines/fax_machine.yml
  • Resources/Prototypes/Entities/Structures/Machines/flatpacker.yml
  • Resources/Prototypes/Entities/Structures/Machines/lathe.yml
  • Resources/Prototypes/Entities/Structures/Machines/microwave.yml
  • Resources/Prototypes/Entities/Structures/Machines/reagent_grinder.yml
  • Resources/Prototypes/Entities/Structures/Machines/silo.yml
  • Resources/Prototypes/Entities/Structures/Piping/Disposal/units.yml
  • Resources/Prototypes/Entities/Structures/Power/Generation/Singularity/collector.yml
  • Resources/Prototypes/Entities/Structures/Storage/Canisters/gas_canisters.yml
  • Resources/Prototypes/Guidebook/engineering.yml
  • Resources/Prototypes/Recipes/Lathes/Packs/science.yml
  • Resources/Prototypes/Recipes/Lathes/machine_boards.yml
  • Resources/Prototypes/Research/industrial.yml
  • Resources/Prototypes/_DV/Entities/Objects/Tools/lathe_upgrade_kits.yml
  • Resources/Prototypes/_DV/Recipes/Lathes/Packs/engineering.yml
  • Resources/Prototypes/_DV/Recipes/Lathes/upgrade_kits.yml
  • Resources/Prototypes/_Goobstation/DeviceLink/sink_ports.yml
  • Resources/Prototypes/_Goobstation/DeviceLink/source_ports.yml
  • Resources/Prototypes/_Goobstation/Entities/Objects/Devices/Circuitboards/machine.yml
  • Resources/Prototypes/_Goobstation/Entities/Objects/Misc/filters.yml
  • Resources/Prototypes/_Goobstation/Entities/Objects/Tools/upgrade_kits.yml
  • Resources/Prototypes/_Goobstation/Entities/Structures/Machines/constructor.yml
  • Resources/Prototypes/_Goobstation/Entities/Structures/Machines/interactor.yml
  • Resources/Prototypes/_Goobstation/Entities/Structures/Machines/robotic_arm.yml
  • Resources/Prototypes/_Goobstation/Entities/Structures/Machines/storage_bin.yml
  • Resources/Prototypes/_Goobstation/Guidebook/engineering.yml
  • Resources/Prototypes/_Goobstation/Recipes/Crafting/Graphs/filters.yml
  • Resources/Prototypes/_Goobstation/Recipes/Crafting/filters.yml
  • Resources/Prototypes/_Goobstation/Recipes/Lathes/Packs/circuits.yml
  • Resources/Prototypes/_Goobstation/Recipes/Lathes/Packs/engineering.yml
  • Resources/Prototypes/_Goobstation/Recipes/Lathes/electronics.yml
  • Resources/Prototypes/_Goobstation/Recipes/Lathes/upgrade_kits.yml
  • Resources/Prototypes/_Shitmed/Entities/Structures/Machines/autodoc.yml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

RSI Diff Bot; head commit a0d3742 merging into 2abaff7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Objects/Tools/lathe_upgrade_kit.rsi

State Old New Status
icon Added

Resources/Textures/_Goobstation/Objects/Misc/filter.rsi

State Old New Status
icon Added

Resources/Textures/_Goobstation/Structures/Machines/constructor.rsi

State Old New Status
icon Added
powered Added

Resources/Textures/_Goobstation/Structures/Machines/interactor.rsi

State Old New Status
active-powered Added
active Added
base Added
empty-powered Added
empty Added
icon Added
inactive-powered Added
inactive Added

Resources/Textures/_Goobstation/Structures/Machines/robotic_arm.rsi

State Old New Status
arm-long Added
arm-short Added
base Added
icon Added
powered Added

Resources/Textures/_Goobstation/Structures/Machines/storage_bin.rsi

State Old New Status
icon Added
powered Added

@Odleer

Odleer commented Aug 8, 2026

Copy link
Copy Markdown
Member

Починить надо

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Нужно сделать

Development

Successfully merging this pull request may close these issues.

7 participants