Skip to content

Add plvision_sonic node kind for PLVision Enterprise SONiC - #3288

Open
romantymoshchuk wants to merge 3 commits into
srl-labs:mainfrom
PVLVision-Support-Team:feat/plvision-sonic
Open

Add plvision_sonic node kind for PLVision Enterprise SONiC#3288
romantymoshchuk wants to merge 3 commits into
srl-labs:mainfrom
PVLVision-Support-Team:feat/plvision-sonic

Conversation

@romantymoshchuk

@romantymoshchuk romantymoshchuk commented Jul 17, 2026

Copy link
Copy Markdown

Summary

  • Add plvision_sonic vrnetlab-based VM kind for Enterprise SONiC Linux Distribution by PLVision
  • Register the kind in core, schema, docs, and mkdocs navigation

Related vrnelab PR: srl-labs/vrnetlab#508

Register a vrnetlab-based VM kind so PLVision Enterprise SONiC images can be deployed with containerlab, including docs, schema, and a lab example.
Describe the target deployment use cases for PLVision Enterprise SONiC in
the containerlab kind reference.
Comment thread schemas/clab.schema.json Outdated
"juniper_csrx",
"sonic-vs",
"sonic-vm",
"sonic-vm",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romantymoshchuk looks like extra whitespace chars got in

nodes:
sonic:
kind: plvision_sonic
image: vrnetlab/plvision_sonic:lite_1_13_202405

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this example, as it is rudimentary - as in it does not show how to use the platform

Comment thread schemas/clab.schema.json Outdated
"sonic-vm": {
"$ref": "#/definitions/node-config"
},
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romantymoshchuk redundant whitespace

 - clean trailing whitespace in schemas/clab.schema.json
 - remove plvision_sonic01 example
@serhii-pukaliak

serhii-pukaliak commented Jul 20, 2026

Copy link
Copy Markdown

@romantymoshchuk

Summary

  • Add plvision_sonic vrnetlab-based VM kind for Enterprise SONiC Linux Distribution by PLVision
  • Register the kind in core, schema, docs, and mkdocs navigation
    > * Include a minimal lab example under lab-examples/plvision_sonic01 - I guess this is outdated for now

Related vrnelab PR: srl-labs/vrnetlab#508

@hellt

hellt commented Jul 28, 2026

Copy link
Copy Markdown
Member

@romantymoshchuk I saw that you closed the vrnetlab part of this. Wil you reopen it or?

@romantymoshchuk

Copy link
Copy Markdown
Author

@romantymoshchuk I saw that you closed the vrnetlab part of this. Wil you reopen it or?

I closed it since vrnetlab PR had been merged. No problem, reopening it.

@hellt

hellt commented Jul 29, 2026

Copy link
Copy Markdown
Member

Ah, got it. I missed that this was an issue and not a Pr

@romantymoshchuk

Copy link
Copy Markdown
Author

Ah, got it. I missed that this was an issue and not a Pr

Any chance you can over fixed changes and review this PR?

@hellt

hellt commented Jul 30, 2026

Copy link
Copy Markdown
Member

Yes, a bit later. I haven't checked if plvision version of sonic can be provided to the maintainers for us to check it?

@romantymoshchuk

Copy link
Copy Markdown
Author

Yes, a bit later. I haven't checked if plvision version of sonic can be provided to the maintainers for us to check it?

Sure, no problem. Where can we send the image to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants