Add containerlab best practices skills - #3256
Draft
FloSch62 wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3256 +/- ##
==========================================
+ Coverage 56.67% 56.80% +0.13%
==========================================
Files 244 244
Lines 25517 25535 +18
==========================================
+ Hits 14461 14505 +44
+ Misses 9390 9360 -30
- Partials 1666 1670 +4
🚀 New features to boost your workflow:
|
hellt
reviewed
Jun 29, 2026
hellt
reviewed
Jun 29, 2026
steiler
reviewed
Jun 30, 2026
| return nil | ||
| } | ||
|
|
||
| if link, ok := l.(runtimeEndpointProvider); ok { |
Collaborator
There was a problem hiding this comment.
this is bad. try to avoid type casts... add the GetRuntimeEndpoints to the Link interface and use it straight away.
remove the runtimeEndpointProvider.
type Link interface {
// ...
GetEndpoints() []Endpoint
// GetRuntimeEndpoints returns endpoints apply/deploy may create, discover, or remove.
// Parent-only and remote metadata endpoints are excluded where applicable.
GetRuntimeEndpoints() []Endpoint
}
Collaborator
The branch mixes:
better pull at least some of it into distinct PRs. |
steiler
reviewed
Jun 30, 2026
| return nil, nil, fmt.Errorf("failed to resolve host veth component for vxlan-stitch") | ||
| } | ||
|
|
||
| // host endpoint is always the 2nd element in the Endpoints slice |
Collaborator
There was a problem hiding this comment.
eps[1] assumes LinkHostRaw.Resolve always returns [node, host]. That's true today but implicit. We already know hostIface here — selecting by ep.GetIfaceName() == hostIface (or a small helper) would make the stitch endpoint choice explicit and order-independent.
FloSch62
changed the title
Member
Author
|
This PR is now only about agent skills/rules |
hellt
added a commit
that referenced
this pull request
Jul 10, 2026
## Summary - move apply runtime endpoint selection onto the `links.Link` contract with `GetRuntimeEndpoints()` - keep stitched-link capability in the `links` package and update apply/deploy callers - persist apply state and reset resolved links for idempotent apply paths - remove short kind aliases from the apply docs table - select the VXLAN stitch endpoint by interface name instead of endpoint slice order ## Validation - `go test ./links ./core ./cmd` Split out from #3256 so that PR can stay focused on agent skills only. --------- Co-authored-by: hellt <dodin.roman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.