Dialog themes added - also diverted into a snippet migration session - #18
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the component library’s dialog system by adding an optional theme prop to DisplayDialog (scoped to the header) and updates related tooling/docs/examples produced during the same migration/snippet session.
Changes:
- Added
theme?: SemanticThemetoDisplayDialog, applying header accent styling and aligning ARIA attributes (aria-labelledby,aria-modal) / role behavior. - Improved dialog state management API typing in
useDialogControlsand refreshed the UI demo page to exercise variants/themes (including a nested-dialog pattern). - Consolidated/renamed VS Code snippet set and added migration tracking/docs updates.
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| MIGRATION.md | Adds a component migration tracker and snippet/consumer-styling status matrix. |
| Claude.md | Updates the component workflow checklist to require snippet creation/updates. |
| app/pages/ui/display-dialog.vue | Refreshes the DisplayDialog demo page (variant/theme QA panel + nested dialog example). |
| app/composables/useDialogControls.ts | Tightens typing for dialog IDs via a generic useDialogControls<T extends string>. |
| app/components/01.atoms/display-dialog/tests/DisplayDialog.spec.ts | Updates role expectations (implicit <dialog> role) and snapshot-related assertions. |
| app/components/01.atoms/display-dialog/tests/snapshots/DisplayDialog.spec.ts.snap | Snapshot updates for new ARIA attributes/structure/classnames. |
| app/components/01.atoms/display-dialog/DisplayDialog.vue | Adds theme prop + header theming hooks; updates ARIA attributes; adds tabindex when content scroll is enabled; adds unmount cleanup. |
| .vscode/srcdev-nuxt3-tabs-component.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-responsive-header-component.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-page-layout.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-layout-row.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-expanding-panel-component.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-display-prompt-component.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-display-details-component.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-display-banner-component.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-dialog-component.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-container-glow-component.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-component-boilerplate.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-carousel-flip-component.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-carousel-basic-component.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-nuxt3-accordian-component.code-snippets | Removes legacy snippet file (replaced by new naming/consolidation). |
| .vscode/srcdev-component-pinia-store.code-snippets | Adds new Pinia store boilerplate snippet(s). |
| .vscode/srcdev-component-display-toast.code-snippets | Adds new DisplayToast/queue/provider snippets under the new naming scheme. |
| .vscode/srcdev-component-display-prompt.code-snippets | Adds new DisplayPrompt snippets under the new naming scheme. |
| .vscode/srcdev-component-dialog.code-snippets | Adds new DisplayDialog + useDialogControls snippets under the new naming scheme. |
| .claude/skills/components/display-dialog.md | Documents the new theme prop and a nested-dialog usage pattern. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
themeprop toDisplayDialogscoped to the header only, along with a batch of supporting improvements made during the same session.DisplayDialog— theme propA
themeprop (typeSemanticTheme) now applies a coloured accent border on the header and tints the close icon to match. Styling is intentionally limited to the header — the dialog body remains neutral to avoid visual noise. Useful for destructive/alert variants where a red theme communicates intent at a glance.<DisplayDialog variant="alert" theme="error" ...>