Form theming - #17
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the form/theming system by introducing a shared AlertContent molecule and refactoring prompts/toasts to use it, alongside adjustments to theme tokens and button geometry.
Changes:
- Added
AlertContent(component, tests, stories) and migratedDisplayToast/DisplayToastProviderandDisplayPromptto use it. - Updated theme token slots (8 → 9, adding
--theme-accent) and adjusted related docs. - Updated button theming/geometry and a few UI demo/QA pages.
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Docs update for 9 semantic theme slots. |
| app/pages/ui/display-toast.vue | QA option update for max visible toasts. |
| app/pages/ui/display-prompt.vue | Reworked prompt demo with a dev-only QA panel + theming toggles. |
| app/layouts/default.vue | Navigation ordering tweak (Prompts link moved). |
| app/components/05.forms/pending-effect/PendingEffect.vue | Formatting-only changes; component already supports theme. |
| app/components/05.forms/input-button/InputButtonCore.vue | Button theming changes and pending effect now receives theme. |
| app/components/02.molecules/alert-content/AlertContent.vue | New shared alert/prompt/toast content component. |
| app/components/02.molecules/alert-content/stories/AlertContent.stories.ts | Storybook coverage for new molecule. |
| app/components/02.molecules/alert-content/tests/AlertContent.spec.ts | Vitest coverage for new molecule. |
| app/components/01.atoms/toast/DisplayToastProvider.vue | Switched provider rendering from DefaultToastContent to AlertContent. |
| app/components/01.atoms/toast/DisplayToast.vue | Switched toast rendering from DefaultToastContent to AlertContent. |
| app/components/01.atoms/toast/molecules/DefaultToastContent.vue | Removed legacy toast content molecule. |
| app/components/01.atoms/toast/tests/DisplayToastProvider.spec.ts | Updated selectors/tests to match AlertContent structure. |
| app/components/01.atoms/toast/tests/DisplayToast.spec.ts | Updated selectors/tests + removed has-theme assertions. |
| app/components/01.atoms/toast/stories/DisplayToast.stories.ts | Updated story args to title/description-style content. |
| app/components/01.atoms/prompt/DisplayPrompt.vue | Refactored to compose AlertContent and map legacy slots. |
| app/components/01.atoms/prompt/tests/DisplayPrompt.spec.ts | Updated selectors/tests to match AlertContent structure. |
| app/components/01.atoms/prompt/stories/DisplayPrompt.stories.ts | Updated story docs/args to reflect new styling approach. |
| app/assets/styles/setup/04.elements/forms/06.button-geometry.css | Button radius adjusted (0.8rem → 0.2rem). |
| app/assets/styles/setup/03.theming/_theme-slots.css | Added --theme-accent and rebalanced several slot mappings. |
| .claude/skills/theming-partial-override.md | Docs updated for new 9-slot vocabulary + slot defaults. |
| .claude/skills/theming-override-default.md | Docs updated for warning theme + accent/surface distinction. |
| .claude/skills/theming-colour-ramps.md | Docs updated for 9 semantic slots and new defaults. |
| .claude/skills/components/display-prompt.md | Docs updated to reference --theme-accent usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to button themes, prompts, toasts and a new shared alert content component