Fix: non-existent JWE algorithm "A265GCM" in normative text; RFC label typo in section 3 - #18
Open
mwiesen wants to merge 1 commit into
Open
Fix: non-existent JWE algorithm "A265GCM" in normative text; RFC label typo in section 3#18mwiesen wants to merge 1 commit into
mwiesen wants to merge 1 commit into
Conversation
…59 label A265GCM is not a registered JWE algorithm; A256GCM (AES-256-GCM) is clearly intended, matching the surrounding prose and all examples. Section 3 mislabels the JSON RFC as 7519 (which is JWT) while linking to 7159; fix the label to match the link. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.
A265GCMshould beA256GCM(3 occurrences)The normative text specified the JWE encryption algorithm as
"enc": "A265GCM"in three places:A265GCMis not a registered JWE algorithm; the intended identifier is clearlyA256GCM("256 bit AES in Galois/Counter Mode", as the surrounding prose says). All examples in the document and the keys in Appendix B already correctly useA256GCM.This is worth fixing promptly because it sits in normative text of a cryptographic spec: an implementer who copies the normative string produces JWE headers that strict JOSE libraries reject, while an implementation that leniently accepts both strings creates a silent interop split.
2. RFC citation label in section 3
Section 3 read: "Data is encoded as JSON according to RFC 7519 "The JavaScript Object Notation (JSON) Data Interchange Format"".
The hyperlink correctly targets RFC 7159, but the visible label said RFC 7519 — which is JWT, not JSON. Fixed the label to RFC 7159 to match the existing link.
Both fixes are one-line changes each.
Disclosure: these findings came out of an AI-assisted review of the spec; I have verified them against the current master text.