Document LocaleContextHolder inheritable behavior#36853
Open
cfcromn wants to merge 1 commit into
Open
Conversation
Signed-off-by: hamin <hamin090403@gmail.com>
cfcromn
force-pushed
the
docs/locale-context-holder-inheritable
branch
from
15bfc38 to
02c4b50
Compare
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36687
This change documents that
LocaleContextHolder'sinheritableflag relies onJDK
InheritableThreadLocalsemantics, which only propagate values to newlycreated child threads at the time of their creation.
In thread pool environments where threads are reused across tasks, the context
is not refreshed per task submission, so this mechanism is not suitable for
per-task context propagation to reused threads.
The documentation now points users toward
TaskDecoratorfor explicit per-tasklocale context propagation.
Verification:
./gradlew :spring-context:compileJava./gradlew :spring-context:test --tests "org.springframework.context.i18n.LocaleContextHolderTests"