Fix Jetty virtual threads configuration#50970
Closed
arnabnandy7 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
Thanks, but we're configuring virtual threads on Jetty as stated in their documentation. The issue you linked is something which only appears on Windows, and therefore should be fixed in Jetty, not in Spring Boot. |
mhalbritter
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50929.
When Jetty and virtual threads are used with Actuator configured on a separate management port, the application can stop responding on Windows after 60 seconds of inactivity.
This change configures Jetty with a
QueuedThreadPooland sets theVirtualThreadPoolas its virtual-threads executor, rather than using theVirtualThreadPooldirectly as the server thread pool. This keeps Jetty infrastructure tasks on platform threads while application tasks can use virtual threads.The existing test has been updated to verify the new thread-pool arrangement and that the configured maximum thread count is retained.