Improve testing of architecture checks

[scottfrederick]

Fixes #47443

There were a couple of problems in the architecture rules that were uncovered by the tests.

When performing checks that involve getting the set of properties on an annotation, like this:

JavaAnnotation<?> annotation = ((HasAnnotations<?>) item).getAnnotationOfType(annotationClass);
Map<String, Object> properties = annotation.getProperties();

The properties map will contain entries for all properties that exist on the annotation class, not just the properties that are set in the source code that uses the annotation. A few rules that assumed only the properties that were explicitly set in the annotation usage would be present in the properties map needed some modification.