Decorate all Assert implementations with @CheckReturnValue

[scordio]

See #32683.

Deliverables

• Annotate all existing Assert implementations
• Build ArchUnit rule to ensure consistency

[snicoll]

See #32683 (comment)

[scordio]

As I need to extend Checkstyle's import-control.xml, would it be fine to add a top-level allow statement close to:

spring-boot/config/checkstyle/import-control.xml

Line 6 in a176849

<allow class="org.springframework.lang.Contract" />

or should I define a more fine-grained rule, restricting it to the following packages?

• org.springframework.boot.test.context.assertj
• org.springframework.boot.test.json

[snicoll]

would it be fine to add a top-level allow statement close to

Yep. The intention is to restrict only to certain AssertJ entry point and this is one of them so I think that's ok.

[snicoll]

@scordio how is it going, anything I can do to help?

[scordio]

Apologies, life happened and this fell off my radar! 🤦

If not in a rush, I'm happy to continue on it over the weekend.

[wilkinsona]

Thanks, @scordio. There's no rush.

[scordio]

When building the project locally, I get two NullAway errors on :core:spring-boot:compileJava:

/Users/stefano/Projects/spring-boot/core/spring-boot/src/main/java/org/springframework/boot/context/properties/bind/ValueObjectBinder.java:424: error: [NullAway] Method returns @Nullable String @Nullable [], but overridden method returns String [], which has mismatched type parameter nullability
		public @Nullable String @Nullable [] getParameterNames(Constructor<?> constructor) {
		                                     ^
    (see http://t.uber.com/nullaway )

/Users/stefano/Projects/spring-boot/core/spring-boot/src/main/java/org/springframework/boot/logging/structured/StructuredLogFormatterFactory.java:240: error: [NullAway] referenced method returns @Nullable, but functional interface method java.util.function.Function.apply(T) returns @NonNull
					ArgumentResolver.from(StructuredLogFormatterFactory.this.instantiator::getArg));
					                      ^
    (see http://t.uber.com/nullaway )

but the CI seems fine 🤔

[snicoll]

@scordio you need Java 24 to build the project

[snicoll]

I've moved to this to 4.x as we're approaching RC1 but not worries either way. Thanks for your efforts!

[wilkinsona]

Thanks very much, @scordio.

I've left a couple of very minor comments. No need for you to do anything about them unless you really want to. We can take care of them when we merge this. That'll take a little while as it'll hopefully go in Spring Boot 4.1 and we need to first get 4.0 out of the door and then create the 4.0.x maintenance branch.

[scordio]

Thanks, @wilkinsona! I'll address them later in the day.

[snicoll]

This PR is ready to be merged once main switches to 4.1.0-SNAPSHOT.

[snicoll]

Good stuff @scordio - Thanks very much!