SOD-7329 Added commonLabels support to the ocean-vpa Helm chart#211
SOD-7329 Added commonLabels support to the ocean-vpa Helm chart#211cshivaraj-patil wants to merge 5 commits into
Conversation
Added commonLabels support to the ocean-vpa Helm chart and verified that labels are applied to supported resources while Pods correctly exclude them.
|
Update the chart version in Chart.yaml file |
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 1.0.2 | ||
| version: 1.0.3 |
There was a problem hiding this comment.
Revert this version bump.
Need not to bump version for admission controller
There was a problem hiding this comment.
Update version in ocean-vpa -->Chart.yaml
…ion-controller chart vesion
There was a problem hiding this comment.
Please remove this trailing h, This change is not from this PR but needs to be removed.
|
Also update README.md file as well with the new version. |
|
Please check this file vpa-webhooks_jobs_certgen-rolebinding_delete_secret.yaml common label is missing. |
|
Please document somewhere that we are “Preserving existing behavior for Pod labeling.” |
|
|
||
| ---------------------------------------------- | ||
| Autogenerated from chart metadata using [helm-docs v1.13.1](https://github.com/norwoodj/helm-docs/releases/v1.13.1) No newline at end of file | ||
| Autogenerated from chart metadata using [helm-docs v1.14.2](https://github.com/norwoodj/helm-docs/releases/v1.14.2) No newline at end of file |
There was a problem hiding this comment.
Helm docs version mismatch with CI.
pipeline runs make docs, and the docs in Makefile.devel.mk currently uses jnorwood/helm-docs:v1.13.1.
This PR appears to have docs generated with a different version (v1.14.2), causing the docs check to fail.
Please either regenerate docs with v1.13.1 or update CI/Makefile.devel.mk to the new version and commit regenerated docs consistently.
Which results in lint stage failure.
|
LGTM |
2 participants
##Jira ticket
https://flexera.atlassian.net/browse/SOD-7329
Summary
This adds support for commonLabels to the Ocean VPA Helm chart.
Applied commonLabels to chart resources such as Deployments, Services, and other Kubernetes objects.
Ensured Pod templates continue to use only podLabels, so commonLabels are not applied to Pods.
Testing
Installed the chart using:
helm install ocean-vpa .
--set commonLabels.environment=dev
--set commonLabels.team=rightsizing
Verified that Deployments and other resources include the configured commonLabels.
Verified that Pods do not include commonLabels.
Confirmed the Helm chart deploys successfully and all resources are in a healthy state.
Screenshots
Installed the chart with:
helm install ocean-vpa .
--set commonLabels.environment=dev
--set commonLabels.team=rightsizing
Deployment labels – ocean-vpa-admission-controller
Verified that commonLabels are applied to the ocean-vpa-updater Deployment.
Verified that commonLabels are applied to the ocean-vpa-admission-controller Deployment.
Verified that the configured commonLabels (environment=dev, team=rightsizing) are present under metadata.labels of the generated Deployment resource.
Verified that Pods do not receive commonLabels.
