This repository was archived by the owner on Mar 28, 2022. It is now read-only.
Improvement of string concatenation by use of buffer#40
Open
polaris197 wants to merge 2 commits into
Open
Conversation
polaris197
commented
Dec 11, 2019
polaris197
left a comment
polaris197
left a comment
Author
There was a problem hiding this comment.
Hi,
This fix is important for all user.
If something wrong, tell me in order to progress.
Can someone at Spotify please merge these fixes into the master?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I test the use of an intermediate buffer on large config and i have a very important improvement.
The same operation take 30 seconds instead of 30 minutes.