Rework, refactor, revamp#10
Closed
abcdefghijorngarbosaxyz wants to merge 26 commits into
Closed
Conversation
Member
Settings should be generated automatically based on the settings model since they change quite often. |
Author
Im thinking of just getting the settings on the |
Author
|
Will open a new PR from fresh fork. Opened #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Rework the current web-ui using vue with typescript, vue-pinia for state management. Changes are based on spotdl CLI dev branch.
To-do
Check for CLI, and web-ui updatesDone on server sidedownloadsand clicking download again #1864DisplayCanceled. Use vue-router insteadsearch,search results,queuein one pageissuelinkWhy and Motivation
My friends and I love to use spotDL. But using the web-ui feels like a bit "outdated", and we encountered some issues using it:
downloadon downloads page passes the file to IDM, then the page reloads, shutting down the server. The same behavior with manually entering thehttp://.../downloadurl in the browser is causing the server to shutdown as it returns{ details: "not found" }. I guess it's normal on SPA apps as the server only has/route.We noticed that web-ui repo is frequently inactive, so we've tried to work on our own version of it.
Please feel free to add some features you'd like to be implemented, on the todos list.