Feature/extend provider resources - #23
Open
mmar6729 wants to merge 3 commits into
Open
Conversation
added 3 commits
March 6, 2026 21:54
- victorops_team: add ImportStatePassthrough importer (import by slug) - victorops_escalation_policy: add ImportStatePassthrough importer (import by slug) - victorops_team_membership: add custom importer accepting 'team_slug/username' format
Allows referencing pre-existing VictorOps resources not managed by Terraform. - data.victorops_user: look up user by username; exposes first_name, last_name, email - data.victorops_team: look up team by slug; exposes name, slug, member_count - data.victorops_escalation_policy: look up policy by name+team Also adds makeAPICall() helper on Config for direct HTTP calls where the SDK does not provide coverage (used by new rotation and scheduled_override resources).
victorops_rotation:
- Manages on-call rotation groups for a team
- Supports multiple shifts with timezone, duration, usernames, and day/time masks
- Resource ID: {team_slug}/{groupId}
- Note: API returns groupId as integer despite spec saying string
victorops_scheduled_override:
- Creates temporary on-call coverage overrides
- Supports user swaps scoped to specific policies or org-wide
- ForceNew on all fields (API has no PUT; must delete and recreate to change)
victorops_paging_policy:
- Manages per-user paging policy steps (how VictorOps notifies a user)
- Supports phone, email, and push notification contacts per step
- Full policy replaced on update (API replaces entire policy on PUT)
mmar6729
force-pushed
the
feature/extend-provider-resources
branch
from
March 6, 2026 10:55
2f3aeaf to
5ae26ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add data sources, import support, and new resources (rotation, scheduled_override, paging_policy)
Summary
Extends the provider with several new capabilities:
New Data Sources
data.victorops_user— look up an existing user by usernamedata.victorops_team— look up an existing team by slugdata.victorops_escalation_policy— look up a policy by name within a teamImport Support
victorops_team—terraform import victorops_team.x <slug>victorops_escalation_policy—terraform import victorops_escalation_policy.x <slug>victorops_team_membership—terraform import victorops_team_membership.x <team_slug>/<username>New Resources
victorops_rotation— manages on-call rotation groups for a teamvictorops_scheduled_override— temporary on-call coverage swapsvictorops_paging_policy— per-user notification step configurationNotes
groupIdas an integer in rotation responses despite the spec saying string — handled in the rotation Read functionmask.time_rangeis required by the live API even when the spec marks it optionalwebsite/docs/