Upgrade to terraform-plugin-sdk/v2 and add new resources/data sources - #22
Open
aamirk-splunk wants to merge 1 commit into
Open
Upgrade to terraform-plugin-sdk/v2 and add new resources/data sources#22aamirk-splunk wants to merge 1 commit into
aamirk-splunk wants to merge 1 commit into
Conversation
- Upgrade from terraform-plugin-sdk v1.8 to v2 - Migrate all resources to Context-based CRUD functions - Return diag.Diagnostics instead of error for richer error reporting - Add import support for team, user, contact, escalation_policy, routing_key, scheduled_override, maintenance_mode, alert_rule resources New Resources: - victorops_scheduled_override: Manage scheduled overrides on escalation policies - victorops_maintenance_mode: Manage maintenance mode windows - victorops_alert_rule: Manage alert rules on routing keys New Data Sources: - victorops_user / victorops_users: Look up users - victorops_team / victorops_teams: Look up teams - victorops_escalation_policy / victorops_escalation_policies: Look up policies - victorops_routing_keys: List all routing keys - victorops_rotations: List team rotations - victorops_on_call: Get current on-call schedule Breaking Changes: - Requires Terraform 0.12+ - Uses terraform-plugin-sdk/v2
aamirk-splunk
force-pushed
the
aamirk/provider-sdk-v2-upgrade
branch
from
December 18, 2025 13:49
3f6a52d to
444636a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes the VictorOps Terraform provider by upgrading to terraform-plugin-sdk/v2 and adding new resources and data sources.
SDK Upgrade
Key Changes
CreateContext,ReadContext,UpdateContext,DeleteContext)errortodiag.Diagnosticsfor richer error reportingschema.ResourceImporterNew Resources
victorops_scheduled_overridevictorops_maintenance_modevictorops_alert_ruleNew Data Sources
victorops_uservictorops_usersvictorops_teamvictorops_teamsvictorops_escalation_policyvictorops_escalation_policiesvictorops_routing_keysvictorops_rotationsvictorops_on_callImport Support
Added import support for all applicable resources:
victorops_team{team_slug}victorops_user{username}victorops_contact{username}/{type}/{contact_id}victorops_escalation_policy{policy_id}victorops_routing_key{routing_key_name}victorops_scheduled_override{policy_slug}/{override_id}victorops_maintenance_mode{instance_id}victorops_alert_rule{routing_key}/{rule_id}Breaking Changes
Version Compatibility