Refactor and UX: PDF rendering improvements#313
Merged
Conversation
- Creates `editor/pdf_renderer.js` containing the Cloud Run POST and polling logic. - Updates `editor/index.html` to use the shared logic. - Updates `songbook_edit.js` and `songbook_edit.html` to use the shared logic. - Updates `src/html/index_generator.py` to deploy `pdf_renderer.js` for the Songbook Editor.
- Opens a blank tab immediately to avoid browser popup blockers - Updates pdf_renderer.js to pass URLs back to callers - Moves 'Generuj Śpiewnik (PDF)' to top level actions in Songbook Editor - Hides 'Generuj kod YAML' inside an Advanced Options details tag - Adds an explicit 'Pobierz PDF' download link button in the UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the duplicated PDF rendering logic into a shared module and applies several UX improvements based on feedback.
Changes
editor/pdf_renderer.js.index_generator.pyto deploy this shared script to the root directory for the Songbook Editor to use.renderPdfCloudRunfunction.