Split html layout for kindle from web-one#289
Merged
Conversation
ptabor
commented
Nov 2, 2025
ptabor
commented
- refactor: separate song conversion logic into modular components
- refactor: rename create_songs_html.py to standard_html_converter
- Better layout.
- Songs in a new format generated.
- Create abstract SongConverter interface to allow multiple HTML generation strategies - Move shared utility functions to song_utils.py - Refactor StandardHtmlConverter to implement SongConverter interface - Add proper package structure with __init__.py - Fix imports to use absolute paths This change enables better separation of concerns and allows for alternative HTML generation implementations (e.g. Kindle-specific format) while maintaining shared utility functions.
- Move StandardHtmlConverter to dedicated file - Update imports to reflect new file name - Prepare for separation of HTML generation strategies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.