fix(lint): ignore ruff PLR0917 so trunk passes ruff check - #178
Closed
claudespice wants to merge 1 commit into
Closed
fix(lint): ignore ruff PLR0917 so trunk passes ruff check#178claudespice wants to merge 1 commit into
claudespice wants to merge 1 commit into
Conversation
`ruff check spicepy tests` fails on trunk with two PLR0917
"Too many positional arguments" errors, both in spicepy/_client.py.
Every open pull request inherits the failure, so the ruff lint job is
red regardless of what the branch changes.
The lint config already ignores PLR0913 ("Too many arguments"), and
both flagged constructors carry an in-code `# pylint: disable=R0917` --
the pylint name for the same rule -- so the intent to allow them was
already recorded; only ruff's half of the pair was missing.
Client.__init__ is the public SDK constructor, so making its
parameters keyword-only to satisfy the rule would break callers that
pass them positionally.
This was referenced Aug 1, 2026
Contributor
Author
|
Closing as a duplicate — #176 already carries this exact fix, and it predates this PR by five days. I opened this after confirming Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruff check spicepy tests— the command theLint with ruffjob runs — fails on trunk itself with two errors, so every open pull request inherits a red ruff job regardless of what it changes:Verified against a clean checkout of trunk (
a199cfa) with ruff 0.16.1: two errors, no branch involved.Why ignore rather than refactor
The lint config already ignores
PLR0913("Too many arguments in function definition"), and both flagged constructors carry an in-code# pylint: disable=R0917— pylint's name for this same rule. The decision to allow these signatures was already made and recorded in two places; only ruff's half of the pair was missing fromignore.Client.__init__is the public SDK constructor. Satisfying the rule for real would mean making its parameters keyword-only, which breaks every caller that passes them positionally — not an acceptable trade for a lint warning the project has already opted out of under its pylint name.Test plan
ruff check spicepy tests→All checks passed!(was:Found 2 errors.)black --check spicepy tests→ unchanged, 22 files clean