Fix json_strings recipe: refresh output captured on Spice v1.x - #561
Open
claudespice wants to merge 1 commit into
Open
Fix json_strings recipe: refresh output captured on Spice v1.x#561claudespice wants to merge 1 commit into
claudespice wants to merge 1 commit into
Conversation
Every console block in this recipe was captured on a 2024 v1.x runtime.
Re-ran the recipe end to end against stable v2.1.2 and replaced the
output with what it actually prints:
- SQL results now carry a data-type row under the column names, and
column names are centered (`format_batches_with_types`, used by the
SQL REPL since v2.0.0).
- `describe` returns four columns; it gained a leading `table_schema`.
- The derived column for `properties->'inventory'` is now
`properties -> 'inventory'`, not `products.properties -> Utf8("inventory")`.
- The startup log no longer reports a metrics listener on 9090 or an
OpenTelemetry listener on 50052, and the results-cache line is now
three separate sql/search/embeddings cache lines.
Values and row counts are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every console block in this recipe was captured on a v1.x runtime in December 2024. I re-ran the recipe end to end against stable v2.1.2 and replaced the blocks with what it actually prints today. Values and row counts are unchanged — only the output shape drifted.
format_batches_with_types, which prints the column types under the names and centers the header. The recipe showed the older untyped, left-aligned header.describereturns four columns. It gained a leadingtable_schema; the recipe showed three.->derived column name changed.properties->'inventory'now projects asproperties -> 'inventory', notproducts.properties -> Utf8("inventory").127.0.0.1:9090and an OpenTelemetry listener on127.0.0.1:50052— neither is emitted by a default v2.1.2 run — andInitialized results cache;is now three separatesql/search/embeddingscache lines.Verified against
spiceai/spiceaiatv2.1.2—crates/repl/src/pretty.rs(format_batches_with_types, unconditional in non-expanded mode) andcrates/repl/src/lib.rs.Evidence
Ran it. Official
v2.1.2release binaries, this recipe's ownspicepod.yaml, this recipe's own queries in README order:Every table in the diff is pasted from that session (the per-query
Time:lines are dropped, matching the recipe's existing style).Note for maintainers
The missing type row is not specific to this recipe — 74 of the cookbook's READMEs show the pre-v2.0 untyped header. Two recipes captured on v2.x (
catalogs/unity_catalog,elasticsearch/connector) already show the typed form, so the repo is currently inconsistent. This PR fixes one recipe that runs locally with no Docker or secrets; the rest need a run each to regenerate honestly. Happy to work through them if that is wanted — or to hold off, if the type row is considered noise that should change on the CLI side instead.