Fix hashed_partitioning recipe: correct copy-pasted Spicepod name - #559
Open
claudespice wants to merge 1 commit into
Open
Fix hashed_partitioning recipe: correct copy-pasted Spicepod name#559claudespice wants to merge 1 commit into
claudespice wants to merge 1 commit into
Conversation
The shipped spicepod.yaml was named duckdb-acceleration-qs, a leftover from the duckdb/accelerator recipe (which creates that app via 'spice init duckdb-acceleration-qs'). This recipe is clone-and-run, so the pod the reader actually loads contradicted the 'name: hashed-partitioning' shown in Step 2 of its own README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hashed_partitioning/spicepod.yamldeclaresname: duckdb-acceleration-qs— a leftover copied from theduckdb/acceleratorrecipe, which builds its app withspice init duckdb-acceleration-qs.name: hashed-partitioning.git clone+cd cookbook/hashed_partitioning, and Step 3 isspice run— so the reader runs the shipped file, which announces itself asduckdb-acceleration-qs.The two files were otherwise byte-identical, so this was the only divergence between what the README shows and what the recipe runs.
Verified against
spiceai/spiceaiatv2.1.2. The podnameis a free-form label (crates/spicepod), so this is a naming/consistency fix rather than a runtime failure — the recipe's queries and partition-pruning plans are unaffected. The colliding name is legitimately owned byduckdb/accelerator/README.md:18.Evidence
Static review only — confirmed by diffing the README's Step 2 YAML block against the committed
spicepod.yaml; the pod name was the sole difference.