Fix docker recipe: use the maintained spiceai/spiceai:latest image - #555
Open
claudespice wants to merge 1 commit into
Open
Fix docker recipe: use the maintained spiceai/spiceai:latest image#555claudespice wants to merge 1 commit into
claudespice wants to merge 1 commit into
Conversation
The recipe built from spiceai/spiceai:latest-models. That tag has not been republished since Spice v1.11.6 - its digest is identical to 1.11.6-models (sha256:fa2dc932..., last pushed 2026-05-07) while :latest now resolves to v2.1.1 (sha256:87076add...). No 2.x release publishes a -models variant. From v2.0 the default release build compiles with the models feature, so model and embedding support (needed here for the local hf_minilm embedding) is in the plain image. Point the Dockerfile at :latest, mirror the change in the README Dockerfile block, note the v1.x -models variant, and correct the version floor to v2.0+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the recipe said
docker/Dockerfile(and the mirroredcat Dockerfileoutput in the README) built from:FROM spiceai/spiceai:latest-modelsThe recipe is titled "Running in Docker" and declares
Works with v1.0+, so a reader reasonably expectslatest-modelsto give them current Spice.What the code does
The
-modelsimage variant is no longer published. The release matrix dropped it in v2.x:.github/workflows/build_and_release.yml:tags: ["default", "models", "odbc"].github/workflows/build_and_release.yml:tags: ["default", "odbc"]— nomodelsentryInstead, the default v2.x build now compiles model support in (v2.1.1 line 244):
So
latest-modelsis frozen on v1.11.6. From the Docker Hub tag API:latestsha256:87076addee02a4d8bfdee99…2.1.1sha256:87076addee02a4d8bfdee99…latest-modelssha256:fa2dc9322359a6825a186d6…1.11.6-modelssha256:fa2dc9322359a6825a186d6…latest-modelsand1.11.6-modelsare byte-identical, and were last pushed a month before v2.0.0 shipped (2026-06-05). No2.0.0-models,2.0.1-models,2.1.0-models, or2.1.1-modelstag exists.The net effect: anyone running this recipe silently gets a v1.11.6 runtime while believing they are on "latest", and that will never change as the tag is no longer updated.
What changed
docker/Dockerfile:FROM spiceai/spiceai:latest-models→FROM spiceai/spiceai:latestdocker/README.md: mirrored the same change in thecat Dockerfileoutput block so the recipe stays self-consistenthf_minilmembedding (spicepod.yaml) — is in the default image from v2.0, and thatv1.xused the separate-modelsvariantv1.0+→v2.0+, since the plainlatesttag only carries model support from v2.0Notes for reviewers
spice statustable are still v1.x-era (Initialized results cache;, anopentelemetry 127.0.0.1:50052row). Those were consistent with the v1.11.6 image the recipe was pinned to, and become stale with this change. I deliberately left them alone rather than hand-writing v2.x output I could not actually observe — happy to follow up with real output if someone can run it, or if you would prefer I take the best-effort edit here.v1.0+and document both tags, say so and I will adjust.Verified against
spiceai/spiceaiat tagv2.1.1(current stable) andv1.11.6.