Fix iceberg catalog recipe: TPC-H Q1 returns 4 rows, not 10 - #554
Open
claudespice wants to merge 1 commit into
Open
Fix iceberg catalog recipe: TPC-H Q1 returns 4 rows, not 10#554claudespice wants to merge 1 commit into
claudespice wants to merge 1 commit into
Conversation
The Pricing Summary Report Query groups by (l_returnflag, l_linestatus), which yields exactly four groups in TPC-H: (A,F), (N,F), (N,O), (R,F). The recipe's own output block lists those four rows but the summary line claimed 10. The snowflake recipe runs the same query and correctly reports 4 rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the recipe says
catalogs/iceberg/README.mdruns TPC-H Pricing Summary Report Query (Q1) againstice.tpch_sf1.lineitemand shows:What the query returns
Q1 groups by
(l_returnflag, l_linestatus). In TPC-H that pairing yields exactly four groups —(A,F),(N,F),(N,O),(R,F)— which is precisely what the recipe's own output block lists. The10 rowssummary contradicts the four rows printed directly above it.Corroborated inside the cookbook itself:
snowflake/README.mdruns the same Q1 against the Snowflake TPC-H sample and reportsTime: 1.398187833 seconds. 4 rows.What changed
10 rows.→4 rows.— a one-line fix to the expected output. The result table itself was already correct and is untouched.Found by a repo-wide sweep comparing every
N rows.claim against the rows actually shown in the preceding table.