Fix file recipe: replace Markdown downloads that now 404 - #550
Open
claudespice wants to merge 1 commit into
Open
Fix file recipe: replace Markdown downloads that now 404#550claudespice wants to merge 1 commit into
claudespice wants to merge 1 commit into
Conversation
databricks.md and delta-lake.md became directories in spiceai/docs, so curl -O silently writes 14-byte '404: Not Found' files. Swap in ducklake.md and iceberg.md and update the expected query output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the recipe said
file/README.mdStep 1 of the Query Markdown Documents walkthrough downloads four docs pages:What actually happens
databricksanddelta-lakeare now directories inspiceai/docs(website/docs/components/data-connectors/), not flat.mdfiles, so those two URLs 404. Because the script usescurl -Owithout-f, the 404 body is written to disk instead of failing — the reader silently ends up with two junk files:The dataset still loads with 4 rows, so Step 4's output looks right — but two of the four "documents" contain the string
404: Not Found, which quietly defeats the point of the recipe.What changed
Swapped the two dead entries for
ducklake.mdandiceberg.md— both still flat.mdfiles in the same directory, and both keep the lakehouse-connector flavour of the originals. Updated the Step 4 expected output to match.Verified all four download real content:
Checked against current stable Spice
v2.1.1. The download step is confirmed by running it; thespice run/spice sqlsteps were not re-run (no CLI in the audit environment), but nothing about them changes — only the four filenames do.Note for reviewers: adding
-f(or--fail) to thecurlwould make a future breakage loud instead of silent. Left out here to keep the diff to the actual drift, happy to add it if wanted.