Fix redshift recipe: correct the community-build accelerator error message - #549
Open
claudespice wants to merge 1 commit into
Open
Fix redshift recipe: correct the community-build accelerator error message#549claudespice wants to merge 1 commit into
claudespice wants to merge 1 commit into
Conversation
…ssage A stock binary rejects 'engine: postgresql' during dataset init with 'The accelerator engine postgres is not available. Valid engines are arrow, cayenne, duckdb, and sqlite.', not 'Unknown engine: postgres'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the recipe said
redshift/README.mdStep 3 tells readers what a stock-installed runtime does with thewritespicepod'sengine: postgresql:What the code does
Unknown engine: {engine}exists, but it is not the message a reader hits here. It lives inDataAccelerator::create_accelerated_table(crates/runtime/src/dataaccelerator/mod.rs#L266-L271) — reached only after dataset init, which performs its own availability check first and fails there:engine: postgresqlparses successfully —Engine::try_fromaccepts bothpostgresandpostgresql(crates/runtime-acceleration/src/engine.rs#L57-L73) — so the engine is never "unknown". It is simply not registered when the binary is built withoutpostgres-accel, andAcceleratorEngineNotAvailableiscfg-gated to render the community variant (crates/runtime/src/lib.rs#L318-L328):Engine::PostgreSQLrenders aspostgresviaDisplay, so the reader sees:This also matches what
postgres/accelerator/README.mdalready says, so the two recipes now agree.What changed
Quoted the actual error message. The rest of the note is unchanged and verified against
v2.1.1:postgres-accelis still a real, non-defaultspicedfeature (bin/spiced/Cargo.toml#L152), andreleaseandmodelsin the suggestedcargo runline both exist.Static verification only — confirming at runtime would require provisioning a Redshift cluster.