Send Cache-Control header with value no-cache - #204
Merged
Conversation
|
I also believe that this fixes the problem described in #196. |
Contributor
Author
|
@AA-Turner is something else needed? |
AA-Turner
approved these changes
Dec 16, 2025
Member
|
Sorry, I'd missed this PR. A |
Contributor
Author
|
@AA-Turner no problem, thanks a lot for reviewing and merging! |
Contributor
Author
|
@AA-Turner is there a release planned? It would be good to have this fix available in a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When modifying a page that is currently not shown in the browser, we noticed that when navigating to it later browsers (especially Safari on macOS) often served the old version of the page that was seen before the update happened. Force-refreshing the page shows the correct content, but this caused confusion for some of my colleagues who didn't think of this right away.
This can simply be mitigated by returning the
Cache-Controlheader with valueno-cache(https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/Caching#force_revalidation). This makes browsers validate whether the content is still fresh before serving the cached copy, and will ensure that no outdated content is shown when sphinx-autobuild is used.Related: #196 (I'm not 100% sure I fully understand the problem mentioned there; but the suggested fix there is what this PR implements)