Quality sprint: consolidate datasources, user-service metrics, sim client coverage#154
Merged
Conversation
…sim client coverage Remove duplicate "Prometheus (App)" datasource — both pointed to the same Prometheus instance. All dashboards now use uid "prometheus". Remove user-service from Spring Boot metric template variables since it emits prometheus-net metrics (different naming convention). Add prometheus-net to user-service so /actuator/prometheus actually serves metrics. Expand sim client to exercise getAccountById, getAccountTransactions, and getTransaction endpoints. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ck endpoints Exercise 5 previously uncovered endpoints: POST deposit/withdraw/transfer (dedicated variants), GET check-username, GET check-email. New users check availability before registering. 30% of transactions use the dedicated endpoint instead of the generic create path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Error Rate by Service chart and Errors by Endpoint table now link to Jaeger Explore filtered by service name with error=true tag. Supports the demo flow: see error spike → click service → view traces. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Demo has several observability gaps: duplicate Prometheus datasources confuse the Grafana UI, user-service has no metrics endpoint (Prometheus scrape silently fails), and the sim client only exercises 12 of 15 available API endpoints.
Solution
/actuator/prometheusserves real metricsgetAccountById,getAccountTransactions, andgetTransactionPart of S-12002.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com