IsEmpty() checks were missing before some SwitchMemtable() invocation…#808
Open
pranavshenoy wants to merge 2 commits into
Open
IsEmpty() checks were missing before some SwitchMemtable() invocation…#808pranavshenoy wants to merge 2 commits into
pranavshenoy wants to merge 2 commits into
Conversation
ofriedma
self-requested a review
January 23, 2024 08:58
ofriedma
suggested changes
Jan 23, 2024
ofriedma
left a comment
Contributor
There was a problem hiding this comment.
@pranavshenoy thank you for your contribution.
Currently there are some tests that are failing with this code changes, that should be addressed before merging.
4550 - DBTest.DeletingOldWalAfterDrop (Failed)
12804 - DBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(false, false, 1, 0) (Failed)
12805 - DBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(false, true, 1, 0) (Failed)
12806 - DBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(false, true, 1, 1) (Failed)
12807 - DBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(false, false, 2, 0) (Failed)
12808 - DBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(false, true, 2, 0) (Failed)
13294 - StackableDBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(true, true, 1, 0) (Failed)
13295 - StackableDBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(true, true, 2, 0) (Failed)
|
PRANAV SHENOY seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: facebook/rocksdb#12179
There was one instance where the IsEmpty() check was missing:
rocksdb/db/db_impl/db_impl_write.cc
Line 1706 in 21d5a8f
status = SwitchMemtable(cfd, write_context);
Having one check inside SwitchMemTable() will ensure there won't be misses in the future.