style fixes to homepage, removed tags from search - #279
Merged
Conversation
Contributor
WalkthroughThe search configuration now excludes team members, categories, and case study tags from indexing. Search results for team members and business partners now link to Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@website/modules/cases-tags/index.js`:
- Line 12: Verify Apostrophe 4.17.0’s behavior for disabling searchable piece
types and add the required deployment/reindex step to remove stale search
documents. Apply this for case-study tags at
website/modules/cases-tags/index.js:12-12, categories at
website/modules/categories/index.js:7-7, and team members at
website/modules/team-members/index.js:8-8.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 30d0a2a2-eec3-4447-921e-9ca901daed89
📒 Files selected for processing (5)
website/modules/@apostrophecms/search/views/index.htmlwebsite/modules/cases-tags/index.jswebsite/modules/categories/index.jswebsite/modules/home-simplified/public/css/home-simplified.csswebsite/modules/team-members/index.js
| title: 1, | ||
| }, | ||
| shortcut: false, | ||
| searchable: false, |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win
Rebuild or clean the search index when disabling these piece types.
Changing searchable may not remove documents already present in the search index. Verify Apostrophe 4.17.0 behavior and add the required deployment/reindex step.
website/modules/cases-tags/index.js#L12-L12: remove existing case-study tag documents.website/modules/categories/index.js#L7-L7: remove existing category documents.website/modules/team-members/index.js#L8-L8: remove existing team-member documents.
📍 Affects 3 files
website/modules/cases-tags/index.js#L12-L12(this comment)website/modules/categories/index.js#L7-L7website/modules/team-members/index.js#L8-L8
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@website/modules/cases-tags/index.js` at line 12, Verify Apostrophe 4.17.0’s
behavior for disabling searchable piece types and add the required
deployment/reindex step to remove stale search documents. Apply this for
case-study tags at website/modules/cases-tags/index.js:12-12, categories at
website/modules/categories/index.js:7-7, and team members at
website/modules/team-members/index.js:8-8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated homepage hero typography with tighter letter spacing across desktop and mobile layouts. Removed search indexing for case study tags, categories, and team members, and routed team-member and business-partner search results to the shared
/casespage. These changes simplify search behavior while aligning homepage heading styles with the updated visual design.