Skip to content

Fix shared-constants module registration #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anton-88 merged 7 commits into from
Jul 1, 2025
Merged

Fix shared-constants module registration #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aaee6b3
Fix shared-constants module registration in app.js
yuramax Jun 24, 2025
f8016e3
Fix generate_constants.js to correctly generate data
yuramax Jun 24, 2025
7c0b098
Fix string escaping vulnerability in generate_constants.js
yuramax Jun 24, 2025
3645afe
Fix quote style in generated constants to match ESLint/Prettier rules
yuramax Jun 24, 2025
ba36182
Fix CodeQL security vulnerability: escape backslashes in string gener…
yuramax Jun 24, 2025
ccd093c
Add trailing comma to generated constants for ESLint/Prettier compliance
yuramax Jun 24, 2025
a77bb58
Merge branch 'main' into fix/shared-constants-module
Anton-88 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion website/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function createAposConfig() {
'global-data': {},

// Shared constants module
'shared-constants': {},
'@apostrophecms/shared-constants': {},

// Configure page types
'@apostrophecms/rich-text-widget': {},
Expand Down
16 changes: 14 additions & 2 deletions website/scripts/generate_constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,18 @@ try {
);
}

// Helper function to safely stringify object with single quotes
const stringifyWithSingleQuotes = (obj, indent = 2) => {
const spaces = ' '.repeat(indent);
const entries = Object.entries(obj)
.map(
([key, value]) =>
`${spaces}${key}: '${String(value).replace(/\\/gu, '\\\\').replace(/'/gu, "\\'")}'`,
)
.join(',\n');
return `{\n${entries},\n${' '.repeat(indent - 2)}}`;
};

// Generate client-side constants file content
const clientFileContent = `/*
* Client-side access to shared constants.
Expand All @@ -44,12 +56,12 @@ try {
*/

// Direct export of constants for import { STANDARD_FORM_FIELD_NAMES } from '...'
export const STANDARD_FORM_FIELD_NAMES = ${JSON.stringify(STANDARD_FORM_FIELD_NAMES, null, 2)};
export const STANDARD_FORM_FIELD_NAMES = ${stringifyWithSingleQuotes(STANDARD_FORM_FIELD_NAMES)};

// Default export function for backwards compatibility
export default () => {
return {
STANDARD_FORM_FIELD_NAMES
STANDARD_FORM_FIELD_NAMES,
};
};
`;
Expand Down
Loading