Update Dockerfile.n8n to use n8n version 1.109.2 and install additional packages - #101
Update Dockerfile.n8n to use n8n version 1.109.2 and install additional packages#101anatolyshipitz wants to merge 4 commits into
Conversation
- Updated `FinAppRepository` to include `contractType` in data retrieval for employees and projects. - Introduced `getContractTypeByDate` utility function to fetch contract types based on date. - Modified `WeeklyFinancialReportRepository` and formatter to incorporate contract type in report generation. - Updated tests to reflect changes in data structure and report formatting. These enhancements improve the accuracy and detail of financial reports, providing clearer insights into contract types alongside revenue metrics.
- Replace string date comparison with timestamp comparison - Add validation to handle invalid dates gracefully - Filter out invalid dates from contract type history - Ensure reliable contract type determination using numeric timestamps
- Introduced comprehensive tests for the getContractTypeByDate utility function. - Covered various scenarios including handling of undefined and empty inputs, invalid dates, and correct contract type retrieval based on date. - Ensured robustness by testing edge cases and filtering out invalid entries in contractTypeHistory. These tests enhance the reliability of the contract type determination logic and improve overall code quality.
…al packages - Upgraded base image from n8nio/n8n:1.89.2 to n8nio/n8n:1.109.2. - Added installation of showdown and slackify-markdown packages with specified versions. - Combined package installations into a single layer for efficiency. - Configured external modules allowlist for Code/Function nodes. These changes enhance the n8n environment by ensuring compatibility with newer package versions and improving the installation process.
|
Caution Review failedThe pull request is closed. WalkthroughAdds contractType support across FinApp schemas, repository projections, utilities, and weekly financial report formatting/aggregation. Introduces getContractTypeByDate utility with tests. Updates related tests and project mock data to include name. Upgrades Dockerfile.n8n base image and installs showdown and slackify-markdown with external module allowance. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Scheduler as Scheduler
participant WFRRepo as WeeklyFinancialReportRepository
participant FinRepo as FinAppRepository
participant Util as getContractTypeByDate
participant Formatter as WeeklyFinancialReportFormatter
Scheduler->>WFRRepo: generateWeeklyReport(targetDate)
WFRRepo->>FinRepo: getProjectsByRedmineIds(ids, projection includes history.contractType)
FinRepo-->>WFRRepo: Projects with history.rate and history.contractType
loop For each group/project
WFRRepo->>Util: getContractTypeByDate(contractTypeHistory, targetDate)
Util-->>WFRRepo: contractType | undefined
WFRRepo->>Formatter: formatDetail({... , contractType})
Formatter-->>WFRRepo: formatted detail line(s)
end
WFRRepo-->>Scheduler: Aggregated report with contractType in details
note over WFRRepo,Formatter: New/updated interactions for contractType computation and rendering
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (12)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
These changes enhance the n8n environment by ensuring compatibility with newer package versions and improving the installation process.
Summary by CodeRabbit
New Features
Chores
Tests