Submit Review Page Frontend#474
Open
mdwerneken wants to merge 1 commit into
Open
Conversation
Need to route to this page in main app file where desired. Still need to connect to backend and route "Close" button to preferred destination (likely home, but may depend on previous location so need to check). And double check that there are all the desired input fields/items.
erin2722
requested changes
Jan 9, 2022
erin2722
left a comment
erin2722
left a comment
Contributor
There was a problem hiding this comment.
looks pretty good!
what you wrote as far as remaining tasks is spot on, as well as the comments i left here
| @@ -0,0 +1,172 @@ | |||
| import React, { useState } from 'react'; | |||
| import styled from 'styled-components'; | |||
| import '../css/SubmitReview.css'; | |||
Contributor
There was a problem hiding this comment.
could probably only use styled-components here, no external css file
| id="dd" | ||
| onSelect={setBuilding} | ||
| > | ||
| <Dropdown.Item className="item" eventKey="47 Claremont">47 Claremont</Dropdown.Item> |
Contributor
There was a problem hiding this comment.
probably want to use map with the dorm names pulled from the API
| <Dropdown.Item className="item" eventKey="2019">2019</Dropdown.Item> | ||
| <Dropdown.Item className="item" eventKey="2020">2020</Dropdown.Item> | ||
| <Dropdown.Item className="item" eventKey="2021">2021</Dropdown.Item> | ||
| <Dropdown.Item className="item" eventKey="Furnald Hall">Furnald Hall</Dropdown.Item> |
Contributor
There was a problem hiding this comment.
probably want to dynamically generate this based on the current year
| } | ||
|
|
||
| body { | ||
| background-color: #707070; |
Contributor
There was a problem hiding this comment.
i think this is affecting the regular reviews page also
| user: process.env.SHAFTUSER, | ||
| password: process.env.SHAFTPASSWORD, | ||
| database: process.env.SHAFTDATABASE | ||
| host: "192.34.62.10", |
Contributor
There was a problem hiding this comment.
will want to take out before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to route to this page in main app file where desired. Still need to connect to backend and route "Close" button to preferred destination (likely home, but may depend on previous location so need to check). And double check that there are all the desired input fields/items.