chore: protect internal role grants#3115
Open
tgmendes wants to merge 1 commit into
Open
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
b7d7b60 to
91f9859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
risk_policy:evaluategrants live inprincipal_grants, but they are internal relation rows, not grants that should be managed by the Roles & Permissions editor.Without this protection, saving a role through the existing RBAC editor would replace all grants for that role principal and accidentally delete policy audience membership rows. That would make unrelated role edits silently change which risk policies apply.
What changed
DeletePrincipalGrantsByScopeas the generic SQLC primitive for deleting a principal's grants by explicit scope list.