fix: share template function maps via base template to avoid per-execution copying#24
Merged
Merged
Conversation
…ution copying Each call to execTemplate previously called template.New(name).Funcs(TmplFuncs), which copies every function entry and calls reflect.ValueOf on each one. With 100+ functions (sprig + custom), this dominated allocations in high-volume workloads (~784MB in a moderate sized source profile). A shared base template is now created once and reused via baseTemplate.New(name), which shares the internal function maps by pointer through Go's text/template common struct. The base template is rebuilt only when template functions are registered or unregistered at runtime.
mfbx9da4
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each call to
execTemplatepreviously calledtemplate.New(name).Funcs(TmplFuncs), which copies every function entry and callsreflect.ValueOfon each one. With 100+ functions (sprig + custom), this dominated allocations in high-volume workloads (~784MB in a moderate sized source profile).A shared base template is now created once and reused via
baseTemplate.New(name), which shares the internal function maps by pointer through Go'stext/templatecommon struct. The base template is rebuilt only when template functions are registered or unregistered at runtime.Test plan