feat: Added Query Performance Monitoring support for RDS#34
Open
spathlavath wants to merge 36 commits into
Open
feat: Added Query Performance Monitoring support for RDS#34spathlavath wants to merge 36 commits into
spathlavath wants to merge 36 commits into
Conversation
spathlavath
commented
Apr 2, 2025
spathlavath
commented
Owner
- Added Query Performance Monitoring support for RDS
- Added QueryMonitoringOnly flag to enable only query monitoring feature
- Updated isSupportedStatement to normalize case of both query and SupportedStatements
… SupportedStatements.
pkulkarni-newrelic
left a comment
pkulkarni-newrelic
left a comment
Collaborator
There was a problem hiding this comment.
@spathlavath
General Comment -
- Make sure what is shipped is not disturbed because these new changes related to RDS.
- These new changes should be compatible with on host DB i,e MySQL and RDS both. If not then handle it conditionally. Like stored procedure, changes in finding the wait, statements and locks.
NOTE : It seems critical changes to me, Take time to do the one time regression testing on onhost MySQL and RDS with these new changes.
…ysql into query-plan-fix
spathlavath
force-pushed
the
query-plan-fix
branch
from
May 15, 2025 14:39
c330cdf to
420267b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.