Skip to content

osg-ca-certs: avoid StandardVersion -> str warning#5333

Open
wdconinc wants to merge 1 commit into
developfrom
wdconinc-patch-1
Open

osg-ca-certs: avoid StandardVersion -> str warning#5333
wdconinc wants to merge 1 commit into
developfrom
wdconinc-patch-1

Conversation

@wdconinc

Copy link
Copy Markdown
Contributor

This PR fixes osg-ca-certs to avoid the following warning:

#29 230.9 > ==> Warning: /opt/spack-packages/repos/spack_repo/builtin/packages/osg_ca_certs/package.py:59: when setting environment variable OSG_CERTS_VERSION=1.141: value is of type `StandardVersion`, but `str` was expected. This is deprecated and will be an error in Spack v1.0
#29 230.9 > ==> Warning: /opt/spack-packages/repos/spack_repo/builtin/packages/osg_ca_certs/package.py:61: when setting environment variable IGTF_CERTS_VERSION=1.141: value is of type `StandardVersion`, but `str` was expected. This is deprecated and will be an error in Spack v1.0

Copilot AI review requested due to automatic review settings June 25, 2026 16:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the osg-ca-certs Spack package to avoid Spack warnings (and future Spack v1.0 errors) caused by passing StandardVersion values to EnvironmentModifications.set(), which expects str.

Changes:

  • Convert self.version[:2] to str(...) when setting OSG_CERTS_VERSION.
  • Convert self.version[3:] to str(...) when setting IGTF_CERTS_VERSION.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants