Skip to content

Imod: Fix qt dependency, spack csh use and compiler selection #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernhardkaindl merged 3 commits into from
Jun 26, 2026
+10 −1
Merged

Imod: Fix qt dependency, spack csh use and compiler selection #5329

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
383e26e
IMOD: Depends on OpenGL-enabled Qt.
RemiLacroix-IDRIS Jun 25, 2026
d29b068
IMOD: Patch csh scripts shebang to use Spack's tcsh.
RemiLacroix-IDRIS Jun 25, 2026
129c737
IMOD: Try to force the compiler.
RemiLacroix-IDRIS Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion repos/spack_repo/builtin/packages/imod/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class Imod(MakefilePackage, CudaPackage):
depends_on("fortran", type="build")
depends_on("java@17:")

depends_on("qt@5.12:") # Can do with 4.6:, but they themselves recommend 5.12+
depends_on("qt+opengl@5.12:") # Can do with 4.6:, but they themselves recommend 5.12+
depends_on("cuda", when="+cuda")
depends_on("libtiff@4:")
depends_on("fftw@3:", when="+fftw")
Expand All @@ -42,8 +42,17 @@ class Imod(MakefilePackage, CudaPackage):
depends_on("python", type=("run"))

def edit(self, spec, prefix):
# Ensure that Spack-provided tcsh is used
csh = join_path(spec["tcsh"].prefix.bin, "csh")
filter_file("#!/bin/csh", f"#!{csh}", "setup", "manpages/convert", "packMacApps")

configure = Executable("./setup")
configure_args = ["-inst", prefix] # Set up prefix
# Try to help the setup script pick the desired compiler
if spec.satisfies("%gcc"):
configure_args.extend(["-compiler", "gnu"])
elif spec.satisfies("%intel"):
configure_args.extend(["-compiler", "intel"])
configure(*configure_args)

if self.spec.satisfies("+cuda"):
Expand Down
Loading