eccodes: enforce libaec version & set static/shared lib correctly#5326
Open
sibcse wants to merge 2 commits into
Open
eccodes: enforce libaec version & set static/shared lib correctly#5326sibcse wants to merge 2 commits into
sibcse wants to merge 2 commits into
Conversation
sibcse
commented
Jun 25, 2026
sibcse
commented
Contributor
- starting with eccodes 2.47.0, the minimum required libaec version is 1.1.4: https://confluence.ecmwf.int/spaces/ECC/pages/656639695/ecCodes+version+2.47.0+released
- since eccodes 2.46.0, CMakeLists.txt uses ENABLE_USE_SHARED_LIB_AEC; set this in package.py based on libaec's specs instead of using the default: https://github.com/ecmwf/eccodes/blob/c10e8be0c3e27dd2be36a909b06d5d3be6889708/CMakeLists.txt#L158-L166
spackbot-triage
Bot
requested review from
climbfuji,
skosukhin and
victoria-cherkas
climbfuji
approved these changes
Jun 26, 2026
climbfuji
left a comment
climbfuji
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable to me, but I am not the primary maintainer of the package
victoria-cherkas
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.