Update package: Hipblaslt for air-gapped systems#5309
Conversation
williampiat3
force-pushed
the
hipblasltPatch
branch
from
949b55d to
c85f802
Compare
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/hipblaslt/package.py
�[1;34m==> �[0mrunning ruff format
1 file left unchanged
�[1;34m==> �[0mrunning ruff check
�[1m�[91mE501 �[0m�[1mLine too long (143 > 99)�[0m
�[1m�[94m-->�[0m repos/spack_repo/builtin/packages/hipblaslt/package.py:296:100
�[1m�[94m|�[0m
�[1m�[94m294 |�[0m �[1m�[94m…�[0m
�[1m�[94m295 |�[0m �[1m�[94m…�[0mROCROLLER_ENABLE_FETCH)",
�[1m�[94m296 |�[0m �[1m�[94m…�[0md_package(yaml-cpp 0.8.0 QUIET)\n if(NOT yaml-cpp_FOUND AND ROCROLLER_ENABLE_FETCH)",
�[1m�[94m|�[0m �[1m�[91m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
�[1m�[94m297 |�[0m �[1m�[94m…�[0m
�[1m�[94m298 |�[0m �[1m�[94m…�[0m
�[1m�[94m|�[0m
Found 1 error.
I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally! |
| ]: | ||
| depends_on(f"hip@{ver}", when=f"@{ver}") | ||
| depends_on(f"llvm-amdgpu@{ver}", when=f"@{ver}") | ||
| depends_on(f"rocm-cmake@{ver}:", type="build", when=f"@{ver}") |
There was a problem hiding this comment.
just wondering if you've tested this and it was working? For some reason when I tried adding a rocm-cmake dependency it was still attempting to clone rocm-cmake
There was a problem hiding this comment.
It worked with a slight variation of this recipe, but my last cleanup might have altered the outcome I had a test going on with this one as well, let me check
There was a problem hiding this comment.
Notice line 381 the variable FETCHCONTENT_SOURCE_DIR_ROCMCMAKEBUILDTOOLS it points towards the installation of rocm-cmake. This is what prevents the source fetch
I confirm that this recipe works with the added cmake args
There was a problem hiding this comment.
Ok , I missed that. Thank you!
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/hipblaslt/package.py
�[1;34m==> �[0mrunning ruff format
1 file reformatted
�[1;34m==> �[0mrunning ruff check
All checks passed!
�[1;34m==> �[0mstyle checks passed
I've updated the branch with style fixes. |
2 participants
I believe this one is not in another PR but I might be mistaken
This needs PR #5291 to be completed first that's why it is a draft.