lyra: add new package

[jbadwaik]

lyra is a small command line library for C++.

[jbadwaik]

@spackbot fix style

[spackbot-app]

Let me see if I can fix that for you!

[spackbot-app]

I was able to run spack style --fix for you!

spack style --fix

repos/spack_repo/builtin/packages/lyra/package.py
�[1;34m==> �[0mrunning ruff format
1 file left unchanged
�[1;34m==> �[0mrunning ruff check
�[1m�[91mE501 �[0m�[1mLine too long (100 > 99)�[0m
 �[1m�[94m-->�[0m repos/spack_repo/builtin/packages/lyra/package.py:1:100
  �[1m�[94m|�[0m
�[1m�[94m1 |�[0m # --------------------------------------------------------------------------------------------------
  �[1m�[94m|�[0m                                                                                                    �[1m�[91m^�[0m
�[1m�[94m2 |�[0m # SPDX-License-Identifier: Apache-2.0 OR MIT
�[1m�[94m3 |�[0m # Copyright (C) Spack Project Developers. See COPYRIGHT file for details.
  �[1m�[94m|�[0m

�[1m�[91mE501 �[0m�[1mLine too long (100 > 99)�[0m
 �[1m�[94m-->�[0m repos/spack_repo/builtin/packages/lyra/package.py:4:100
  �[1m�[94m|�[0m
�[1m�[94m2 |�[0m # SPDX-License-Identifier: Apache-2.0 OR MIT
�[1m�[94m3 |�[0m # Copyright (C) Spack Project Developers. See COPYRIGHT file for details.
�[1m�[94m4 |�[0m # --------------------------------------------------------------------------------------------------
  �[1m�[94m|�[0m                                                                                                    �[1m�[91m^�[0m
�[1m�[94m5 |�[0m from spack_repo.builtin.build_systems.cmake import CMakePackage
  �[1m�[94m|�[0m

Found 3 errors (1 fixed, 2 remaining).

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

[jbadwaik]

@bernhardkaindl What's going on here? Was there something not working with the PR?

[bernhardkaindl]

@jbadwaik, I'm sorry, a git command went wrong when I wanted to apply a minor edit to the PR remotely.

I saved the your commits (and the small edit I wanted to to before running the CI pipelines) here:

https://github.com/bernhardkaindl/spack-packages/commits/pr-5041-recovered/

I believe the precondition that made this a bit unexpected for me was that the PR branch of this PR is called develop like the main target branch, so this made things a bit awkward.

You can re-pull your changes (while my commit on top) to your spack-packages branch:

git pull https://github.com/bernhardkaindl/spack-packages pr-5041-recovered

I'm not sure if it works on your develop branch which this PR is created from, but it could work and you might be able to reopen the PR from the develop branch after you pushed your local develop branch to your github repo's develop branch.

However, it would likely be more straight-forward if you could create a new branch locally for your new package (develop is the default branch, the 'trunk' of the repo so to say, it does not work well as the basis for PR submissions and it also occupies this default branch in your repos), so I suggest you create a new topic branch for your new package work:

git switch -c lyra-new-package origin/develop # (assuming your origin/develop is an actual develop branch without commits that are already in spack's develop branch)
Then pull from the backup branch

Buth commands should be:

git switch -c lyra-new-package origin/develop
git pull https://github.com/bernhardkaindl/spack-packages pr-5041-rebased

Then you can review and make changes, run a git push to your github repo and open a new PR (or your may try to push to your github repo's develop branch again to reopen this PR but it is less confusing to open a (new) PR with a good branch name that is uniqe and describes your PR well, like lyra-new-package.

I'm sorry for the accident, it was not intentional and was unexpected when it happned.

[jbadwaik]

@bernhardkaindl Ahh, thanks! No worries! Apologies about my branch name. Was not aware about this behavior. I'll follow through. (I do have the commits so it's okay as well, but thanks!)

[bernhardkaindl]

Oh, I'm glad, the nits I had were the file header, and to bump the version to the new version number of the upstream project. The package.py file header which is quite standard in spack, so I think it should be the same for all package recipes; the first 4 lines of all package.py files should be normally (without #-----) these, with an empty line as the 4th line:

# Copyright Spack Project Developers. See COPYRIGHT file for details.
#
# SPDX-License-Identifier: (Apache-2.0 OR MIT)