Do Not Merge: for record keeping only: Odelaytime#84
Open
SaOgaz wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the work I had done so far on translating the Odelaytime IRAF task into Python. I was unable to get completely consistent results between the IRAF version and the Python version. There was discussion with the STIS team about wether or not it made more sense to re-do this function from scratch to figure out the expected results, and or see how accurate the underlying calculation actually is.
If the team decides they do want to continue with the Python port, it's probably best at this point to start the investigation of the un-matching results from scratch with new test data.