ISEB-201: Update defringe_guide.rst mkfringeflat call for E1 position#198
Merged
Conversation
Fixed typo
sean-lockwood
changed the title
Member
Author
|
RTD: |
hayescr
approved these changes
Jun 17, 2026
hayescr
left a comment
hayescr
left a comment
There was a problem hiding this comment.
LGTM from the coding perspective, made one minor comment, but that's just my preference for limiting how much is done on one line for readability. Feel free to take or leave the suggestion!
Revised `extrloc` line for readability. Thanks @hayescr!
Member
Author
|
Thanks, @hayescr! I've incorporated your suggestion: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the docs to suggest E1 observations be defringed by explicitly speciying the extraction position.
Tested by specifying
extrloc=int(round(A2CENTER)):(Note that this only worked after modifying the default
rms_region=[724, 870].)