MRT: Use bottleneck for nanmedian when available#254
Merged
Conversation
Collaborator
Author
|
Timing below is kinda iffy because they ran on VMs, so this only gives a rough estimate. The Python 3.14 job does not pull in Without this patch (master branch)Python 3.10: With this patchPython 3.10: |
41f9a7c to
d1aafca
Compare
Collaborator
Author
|
After switching away from Git LFS (#259), the runtime without bottleneck was 9s. With bottleneck, it went down to 6s. |
but no bottleneck for block_reduce
d1aafca to
6c3431d
Compare
Collaborator
Author
|
After some code clean-up (#262), here are the updated timings. Note that these were all run on VMs, so take it with a grain of salt.
|
Collaborator
Author
|
So far, this is the only one that gives visible performance boost and actually don't change results. So, I am taking it out of draft for formal review. |
dvstark
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to try
bottleneckfor #233RT: https://github.com/spacetelescope/RegressionTests/actions/runs/28265017532 , https://github.com/spacetelescope/RegressionTests/actions/runs/28610438618