Skip to content

MRT: Use bottleneck for nanmedian when available#254

Merged
dvstark merged 1 commit into
spacetelescope:masterfrom
pllim:genie-in-a-bottleneck
Jul 6, 2026
Merged

MRT: Use bottleneck for nanmedian when available#254
dvstark merged 1 commit into
spacetelescope:masterfrom
pllim:genie-in-a-bottleneck

Conversation

@pllim

@pllim pllim commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

@pllim

pllim commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

Timing below is kinda iffy because they ran on VMs, so this only gives a rough estimate. The Python 3.14 job does not pull in bottleneck.

Without this patch (master branch)

Python 3.10: 14.05s call acstools/tests/test_wfc_findsat_mrt.py::test_WfcWrapper

With this patch

Python 3.10: 9.87s call acstools/tests/test_wfc_findsat_mrt.py::test_WfcWrapper

@pllim

pllim commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

After switching away from Git LFS (#259), the runtime without bottleneck was 9s. With bottleneck, it went down to 6s.

but no bottleneck for block_reduce
@pllim pllim force-pushed the genie-in-a-bottleneck branch from d1aafca to 6c3431d Compare July 2, 2026 17:47
@pllim

pllim commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

After some code clean-up (#262), here are the updated timings. Note that these were all run on VMs, so take it with a grain of salt.

  • Without bottleneck (master): 13.39s
  • With bottleneck (this PR): 10.84s

@pllim

pllim commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

So far, this is the only one that gives visible performance boost and actually don't change results. So, I am taking it out of draft for formal review.

@pllim pllim marked this pull request as ready for review July 3, 2026 01:57
@pllim pllim requested a review from dvstark July 3, 2026 02:11
@dvstark dvstark merged commit 0c1f86d into spacetelescope:master Jul 6, 2026
12 checks passed
@pllim pllim deleted the genie-in-a-bottleneck branch July 6, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants