Send ACK even if not all parameters in push request are recognised

[troelsjessen]

When typing switch X in CSH, the client throws a push queue error after the configured timeout and the module is leaving a Param serve push error, result = -1 in stdbuf due to the client also setting parameters boot_img2/3 in case they exist.

Since ack_with_pull was introduced, the user will see the parameters actually set in the ACK, so I see not reason why the server simply shall hold back the ACK in case not all values can be handled.

[johandc]

Why dont we make it an option on the client side, wether they would like full ack of all set params, ack if only a partial was set, or simply just a return of all the set parameters?

[troelsjessen]

Why dont we make it an option on the client side, wether they would like full ack of all set params, ack if only a partial was set, or simply just a return of all the set parameters?

You want another flag in the push request, selecting whether to send an ACK if only some parameters were recognised? Currently, Recent releases of CSH is always setting ack with pull.

Currently we have the following flags defined

[johandc]

Yes, an ACK should only be transmitted if the entirety of the packet has been received and understood. This has been default behaviour, so we cannot change that. In essenece it is not a libparam problem that we set invalid parameters, but a CSH problem. So param is doing what it is supposed to to warn the user that the packet was not completely understood. Adding another flag to the request, could allow us to change that behaviour so it will silently drop invalid params instead.