fix: path traversal#300
Open
InvalidJoker wants to merge 4 commits into
Open
Conversation
freggy
requested changes
May 13, 2026
| name: "cleans paths", | ||
| prevVersion: fixture.FlavorVersion(), | ||
| newVersion: uncleanPathVersion, | ||
| expected: &cleanedPathVersion, |
| ErrMinecraftVersionNotSupported = New(codes.FailedPrecondition, "minecraft version not found") | ||
| ErrHashMismatch = New(codes.FailedPrecondition, "hash does not match") | ||
| ErrInvalidHash = New(codes.InvalidArgument, "invalid hash") | ||
| ErrInvalidPath = New(codes.InvalidArgument, "invalid path") |
Member
There was a problem hiding this comment.
i'd prefer if we provide which paths exactly are invalid. for this we can add the BadRequest message to the error. the comments provide good guideance, on how to use it.
more info on how to implement it:
| @@ -120,10 +120,45 @@ func TestCreateFlavor(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestCreateFlavorVersion(t *testing.T) { | |||
Member
There was a problem hiding this comment.
i'd also prefer if we could have a functional test, that covers the new cases additionally.
# Conflicts: # test/functional/controlplane/chunk_api_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147