Skip to content

fix: make TableIdentifier::normalized fallible #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iajoiner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make TableIdentifier::normalized fallible #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sxt-core/src/tables.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,10 @@ impl TableIdentifier {
}

/// Takes a given Table Identifier and coerces it to uppercase
pub fn normalized(ident: TableIdentifier) -> Self {
let name = from_utf8(&ident.name).unwrap();
let namespace = from_utf8(&ident.namespace).unwrap();
Self::from_str_unchecked(name, namespace)
pub fn normalized(ident: TableIdentifier) -> Result<Self, Utf8Error> {
let name = from_utf8(&ident.name)?;
let namespace = from_utf8(&ident.namespace)?;
Ok(Self::from_str_unchecked(name, namespace))
}

Comment thread
tlovell-sxt marked this conversation as resolved.
/// Optimistically create a Table Identifier from a given name and namespace. If the
Expand Down