fix: remove unused dependencies from simple crates

Cargo.toml

@@ -62,7 +62,6 @@ arrow = { version = "54.2.1", default-features = false }
 attestation_tree = { path = "./attestation_tree/", default-features = false }
 bigdecimal = { version = "0.4.5", default-features = false }
 bincode = { version = "2.0.0", default-features = false }
-const_format = { version = "0.2.33", default-features = false }
 commitment-sql = { path = "./proof-of-sql/commitment-sql/", default-features = false }
 datafusion = { version = "38.0.0", default-features = false }
 eth-ecdsa = { path = "./eth-ecdsa", default-features = false }

arrow-ipc-no-std/src/lib.rs

@@ -1,5 +1,6 @@
 #![doc = include_str!("../README.md")]
 #![cfg_attr(not(feature = "std"), no_std)]
+#![cfg_attr(feature = "std", warn(unused_crate_dependencies))]
 
 #[expect(
     mismatched_lifetime_syntaxes,

attestation_tree/src/lib.rs

@@ -1,4 +1,5 @@
 #![doc = include_str!("../README.md")]
+#![warn(unused_crate_dependencies)]
 
 /// Hash and key types for attestation tree nodes.
 mod hash_and_key;

canaries/Cargo.toml

@@ -8,7 +8,6 @@ repository.workspace = true
 edition.workspace = true
 
 [dependencies]
-hex.workspace = true
 event-forwarder.workspace = true
 clap = { workspace = true, features = ["derive", "env"] }
 tokio = { workspace = true, features = ["full"] }

canaries/src/main.rs

@@ -1,4 +1,6 @@
 //! Canary prototype
+#![warn(unused_crate_dependencies)]
+
 /// Prometheus metrics collection and serving.
 mod metrics;
 /// Parsing utilities for canary data.

chain-utils/src/main.rs

@@ -1,5 +1,6 @@
 //! This utility is built to read a DDL file from a given path and submit it to the SxT Chain
 //! using a given private key.
+#![warn(unused_crate_dependencies)]
 
 mod common;
 mod fetch_submissions;

eth-ecdsa/src/lib.rs

@@ -1,5 +1,6 @@
 #![doc = include_str!("../README.md")]
 #![cfg_attr(not(feature = "std"), no_std)]
+#![cfg_attr(feature = "serde", warn(unused_crate_dependencies))]
 
 /// Ethereum-compatible ECDSA signature implementation.
 mod signature;

native-api/src/lib.rs

@@ -1,5 +1,6 @@
 //! The declaration for the native trait that can be adhered to by pallets that want to execute std code.
 #![cfg_attr(not(feature = "std"), no_std)]
+#![warn(unused_crate_dependencies)]
 
 use proof_of_sql_commitment_map::TableCommitmentBytesPerCommitmentSchemePassBy;
 use sxt_core::native::{NativeCommitmentError, NativeError, OnChainTableBytes, RowData};

node/Cargo.toml

@@ -30,22 +30,18 @@ polkadot-sdk = { workspace = true, features = [
 	"pallet-staking", "sp-authority-discovery",
 	"pallet-transaction-payment", "pallet-transaction-payment-rpc", "frame-benchmarking", "frame-benchmarking-cli",
 ]}
+
+# functionally unused, but these features need to be enabled for rocksdb support
 sc-cli = { workspace = true, features = ["rocksdb"] }
 sc-client-db = { workspace = true, features = ["rocksdb"] }
 
 sxt-runtime.workspace = true
 native.workspace = true
-sxt-core.workspace = true
-proof-of-sql-commitment-map = { workspace = true, features = [ "substrate"] }
 proof-of-sql-static-setups = { workspace = true, features = ["io"] }
-sqlparser = { workspace = true, default-features = false }
-bs58 = "0.5.1"
 dotenv = "0.15.0"
 
-rand.workspace = true
 node-rpc.workspace = true
 serde.workspace = true
-codec = { workspace = true, default-features = true }
 
 [build-dependencies]
 substrate-build-script-utils.workspace = true
@@ -56,7 +52,6 @@ default = ["std"]
 std = [
 	"sxt-runtime/std",
 	"native/std",
-	"sxt-core/std",
 ]
 # Dependencies that are only required if runtime benchmarking should be build.
 runtime-benchmarks = [

node/src/main.rs

@@ -1,5 +1,9 @@
 //! Substrate Node Template CLI library.
 #![warn(missing_docs)]
+#![warn(unused_crate_dependencies)]
+
+// functionally unused, but these features need to be enabled for rocksdb support
+use {sc_cli as _, sc_client_db as _};
 
 /// benchmarking
 mod benchmarking;

pallets/attestation/Cargo.toml

@@ -23,8 +23,8 @@ scale-info = { features = [
 polkadot-sdk = { workspace = true, features = [
 	"frame-benchmarking", "frame-support", "frame-system"
 ]}
-k256 = { version = "0.13.4", default-features = false }
-sha3 = { version = "0.10.8", default-features = false }
+k256 = { workspace = true, default-features = false, optional = true }
+sha3 = { workspace = true, default-features = false, optional = true }
 sxt-core.workspace = true
 pallet-permissions.workspace = true
 pallet-keystore.workspace = true
@@ -33,6 +33,7 @@ pallet-keystore.workspace = true
 polkadot-sdk = { workspace = true, features = [
 	"sp-io", "sp-runtime", "sp-core",
 ]}
+k256 = { workspace = true, default-features = false }
 
 [features]
 default = ["std"]
@@ -48,6 +49,7 @@ std = [
 ]
 runtime-benchmarks = [
 	"polkadot-sdk/runtime-benchmarks",
+        "dep:sha3",
 ]
 try-runtime = [
 	"polkadot-sdk/try-runtime",

pallets/attestation/src/lib.rs

@@ -6,6 +6,7 @@
 //! registration and usage.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![cfg_attr(feature = "runtime-benchmarks", warn(unused_crate_dependencies))]
 
 pub use pallet::*;
 

pallets/indexing/Cargo.toml

@@ -27,12 +27,10 @@ pallet-commitments.workspace = true
 pallet-permissions.workspace = true
 pallet-tables.workspace = true
 pallet-system-tables.workspace = true
-hex.workspace = true
 sxt-core.workspace = true
 
 native-api = { workspace = true, default-features = false}
 postcard.workspace = true
-proof-of-sql-static-setups = { workspace = true, features = ["io"], optional = true }
 on-chain-table = { workspace = true, default-features = false }
 proof-of-sql-commitment-map.workspace = true
 sqlparser = { workspace = true, optional = true }
@@ -43,7 +41,6 @@ snafu.workspace = true
 polkadot-sdk = { workspace = true, features = ["sp-staking", "frame-election-provider-support", "pallet-staking-reward-curve", "pallet-timestamp", "pallet-balances", "pallet-staking", "sp-core", "sp-io", "sp-runtime"]}
 
 proof-of-sql-static-setups = { workspace = true, features = ["io"] }
-native.workspace = true
 arrow.workspace = true
 proof-of-sql-commitment-map.workspace = true
 pallet-zkpay.workspace = true
@@ -57,7 +54,6 @@ std = [
 	"polkadot-sdk/std",
 	"codec/std",
 	"scale-info/std",
-	"native/std",
 	"native-api/std",
 	"on-chain-table/std",
 	"pallet-commitments/std",

pallets/indexing/src/lib.rs

@@ -7,6 +7,7 @@
 
 // We make sure this pallet uses `no_std` for compiling to Wasm.
 #![cfg_attr(not(feature = "std"), no_std)]
+#![cfg_attr(feature = "runtime-benchmarks", warn(unused_crate_dependencies))]
 
 extern crate alloc;
 extern crate core;

pallets/keystore/Cargo.toml

@@ -23,10 +23,11 @@ scale-info = { features = [
 polkadot-sdk = { workspace = true, features = ["frame-benchmarking", "frame-support", "frame-system"] }
 
 sxt-core.workspace = true
-k256 = { version = "0.13.4", default-features = false }
-sha3 = { version = "0.10.8", default-features = false }
+k256 = { workspace = true, default-features = false, optional = true }
+sha3 = { workspace = true, default-features = false, optional = true }
 
 [dev-dependencies]
+k256 = { version = "0.13.4", default-features = false }
 polkadot-sdk = { workspace = true, features = ["sp-core", "sp-io", "sp-runtime",] }
 
 [features]
@@ -41,6 +42,8 @@ std = [
 ]
 runtime-benchmarks = [
 	"polkadot-sdk/runtime-benchmarks",
+        "dep:k256",
+        "dep:sha3",
 ]
 try-runtime = [
 	"polkadot-sdk/try-runtime",

pallets/keystore/src/lib.rs

@@ -2,6 +2,7 @@
 //! Currently only Ethereum style ECDSA keys are supported
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![cfg_attr(feature = "runtime-benchmarks", warn(unused_crate_dependencies))]
 
 pub use pallet::*;
 

pallets/permissions/src/lib.rs

@@ -1,5 +1,6 @@
 //! TODO: add docs
 #![cfg_attr(not(feature = "std"), no_std)]
+#![warn(unused_crate_dependencies)]
 
 extern crate alloc;
 

pallets/rewards/Cargo.toml

@@ -22,18 +22,15 @@ scale-info = { features = [
 
 polkadot-sdk = { workspace = true, features = ["frame-benchmarking", "frame-support", "frame-system", "pallet-balances", "pallet-staking", "pallet-session", "sp-staking", "sp-runtime", "sp-core"] }
 
-pallet-commitments.workspace = true
 
 [dev-dependencies]
 proof-of-sql-static-setups = { workspace = true, features = ["io"] }
 
 polkadot-sdk = { workspace = true, features = ["pallet-balances", "pallet-staking", "sp-authority-discovery", "sp-consensus-babe", "sp-runtime", "sp-staking", "frame-election-provider-support", "pallet-staking-reward-curve", "pallet-authorship", "pallet-timestamp", "pallet-grandpa", "pallet-babe", "pallet-authority-discovery", "sp-core", "sp-io"]}
-env_logger.workspace = true
-native.workspace = true
-arrow.workspace = true
 proof-of-sql-commitment-map.workspace = true
 pallet-permissions.workspace = true
 pallet-tables.workspace = true
+pallet-commitments.workspace = true
 
 [features]
 default = ["std"]

pallets/rewards/src/lib.rs

@@ -5,6 +5,7 @@
 //! rewards and payout one page of nominators(512) at a time for up to 3 validators per block until
 //! all pages for all validators are paid.
 #![cfg_attr(not(feature = "std"), no_std)]
+#![warn(unused_crate_dependencies)]
 
 extern crate alloc;
 extern crate core;

pallets/smartcontracts/Cargo.toml

@@ -39,9 +39,6 @@ proof-of-sql-commitment-map = { workspace = true }
 pallet-commitments.workspace = true
 pallet-system-tables.workspace = true
 pallet-zkpay.workspace = true
-proof-of-sql-static-setups = { workspace = true, features = ["io"] }
-native.workspace = true
-arrow.workspace = true
 
 [features]
 default = ["std"]

pallets/smartcontracts/src/lib.rs

@@ -4,6 +4,7 @@
 
 #![cfg_attr(not(feature = "std"), no_std)]
 #![allow(clippy::large_enum_variant)]
+#![cfg_attr(feature = "runtime-benchmarks", warn(unused_crate_dependencies))]
 
 pub use pallet::*;
 

pallets/system-contracts/src/lib.rs

@@ -1,5 +1,6 @@
 #![doc = include_str!("../README.md")]
 #![cfg_attr(not(feature = "std"), no_std)]
+#![warn(unused_crate_dependencies)]
 
 pub use pallet::*;
 

pallets/system_tables/Cargo.toml

@@ -28,12 +28,10 @@ polkadot-sdk = { workspace = true, features = [
 
 pallet-zkpay.workspace = true
 pallet-tables.workspace = true
-pallet-commitments.workspace = true
 sxt-core = { default-features = false, workspace = true }
 on-chain-table = { workspace = true, default-features = false }
 spin.workspace = true
 hex.workspace = true
-serde_json = { workspace = true, default-features = false, features = ["alloc"] }
 log.workspace = true
 itertools.workspace = true
 
@@ -44,12 +42,13 @@ polkadot-sdk = { workspace = true, features = [
 	"pallet-authority-discovery", "sp-authority-discovery", "sp-consensus-babe", 
 	"sp-core", "sp-io", "sp-runtime",
 	]}
+pallet-commitments.workspace = true
 
 proof-of-sql-static-setups = { workspace = true, features = ["io"] }
 pallet-permissions.workspace = true
 arrow = { workspace = true }
-env_logger.workspace = true
 proof-of-sql-commitment-map.workspace = true
+serde_json = { workspace = true, default-features = false, features = ["alloc"] }
 
 [features]
 default = ["std"]