Add support for Sun Microsystems Help through Cut keys - #6922
Open
DoubleHypercube wants to merge 2 commits into
Open
Add support for Sun Microsystems Help through Cut keys#6922DoubleHypercube wants to merge 2 commits into
DoubleHypercube wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell we lose nothing by supporting these. Tested on a physical Sun Microsystems Type 7.
Front isn't in here because SDL literally does not have a scancode for that. Our only option is to pound sand, I guess.
While writing this PR I also found that
Key.World1has no associated MapKey call. In theory, we could map it toSDL_SCANCODE_INTERNATIONAL1- however, at that point, I would personally honestly say we should just map through World9/SDL_SCANCODE_INTERNATIONAL9as well.Additionally, LShift/RShift, LAlt/RAlt, and LControl/RControl are not distinguished between L/R positions on the keyboard unlike LSystem/RSystem. Is there a reason for this? On many keyboards they're distinct scancodes - the Type 7 in particular has Right Shift and Right Alt (labeled as Alt Graph).
On the subject of Alt, for some reason
Key.Altis specialcased with#if MACOSin InputDevices. This should really be anOperatingSystem#IsMacOScall, which in fact is used directly above for LSystem/RSystem. Why it is not done this way for Alt? At the very least, both checks should use the same logic.