feat!: migrate git to custom resources#210
Merged
Merged
Conversation
damacus
force-pushed
the
feat/git-custom-resource-migration
branch
9 times, most recently
from
9cc6141 to
54e2f5a
Compare
damacus
force-pushed
the
feat/git-custom-resource-migration
branch
from
54e2f5a to
3449594
Compare
Slowest examplesTop 10 slowest examples (0.69 seconds, 92.46% of total time)
|
johnmccrae
added a commit
to chef/chef
that referenced
this pull request
May 12, 2026
git cookbook v13.0.0 (released 2026-05-07) is a breaking change that removed the default recipe in favour of custom resources (sous-chefs/git#210). Policyfile was resolving the latest version, causing: Chef::Exceptions::RecipeNotFound: could not find recipe default for cookbook git Replace include_recipe 'git' with the new custom resource call git_client 'default'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCrae <john.mccrae@progress.com>
johnmccrae
added a commit
to chef/chef
that referenced
this pull request
May 13, 2026
git cookbook v13.0.0 (released 2026-05-07) is a breaking change that removed the default recipe in favour of custom resources (sous-chefs/git#210). Policyfile was resolving the latest version, causing: Chef::Exceptions::RecipeNotFound: could not find recipe default for cookbook git Replace include_recipe 'git' with the new custom resource call git_client 'default'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCrae <john.mccrae@progress.com>
johnmccrae
added a commit
to chef/chef
that referenced
this pull request
May 15, 2026
git cookbook v13.0.0 removed the default recipe in favour of custom resources (sous-chefs/git#210). Replace include_recipe 'git' with git_client 'default' in the macOS recipe, matching the fix already applied to the Linux recipe. Signed-off-by: John McCrae <john.mccrae@progress.com>
johnmccrae
added a commit
to chef/chef
that referenced
this pull request
May 15, 2026
* fix(kitchen-tests): fix nscd exclusion for AL2023 and git workaround on Windows
- Add Amazon Linux 2023 to the nscd exclusion guard in linux.rb.
AL2023 uses platform_family 'amazon' (not 'rhel'), so the existing
RHEL >= 10 guard did not apply, causing nscd install failures since
the package is not available on AL2023.
Also removed the redundant platform?(almalinux/rocky/oracle) sub-condition
as platform_family?('rhel') already covers those platforms.
- Replace the fragile path-based git uninstall workaround and
include_recipe 'git' in windows.rb with chocolatey_package 'git'
(action :upgrade). The previous FIXME band-aid hard-coded install
paths that do not cover Windows 2025 runners and caused version
conflicts. Using chocolatey_package is idempotent, installs the
latest available git version, and avoids the downgrade issue.
- Update metadata.rb supports to include all platforms actually tested
in CI: almalinux, rocky, oracle, windows, freebsd, mac_os_x.
Signed-off-by: John McCrae <john.mccrae@progress.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
* fix(kitchen-tests): migrate to nscd v7 custom resource API
nscd cookbook v7.0.0 (released 2026-05-06) is a breaking change that
removed the default recipe in favour of custom resources (sous-chefs/nscd#61).
Policyfile was resolving the latest version, causing:
Chef::Exceptions::RecipeNotFound: could not find recipe default for cookbook nscd
Replace include_recipe 'nscd' with the new custom resource call and
restore the depends 'nscd' entry in metadata.rb that was accidentally
dropped in a prior commit.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
* fix(kitchen-tests): migrate to git v13 custom resource API
git cookbook v13.0.0 (released 2026-05-07) is a breaking change that
removed the default recipe in favour of custom resources (sous-chefs/git#210).
Policyfile was resolving the latest version, causing:
Chef::Exceptions::RecipeNotFound: could not find recipe default for cookbook git
Replace include_recipe 'git' with the new custom resource call git_client 'default'.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
* fix(kitchen-tests): migrate macos recipe to git v13 custom resource API
git cookbook v13.0.0 removed the default recipe in favour of custom
resources (sous-chefs/git#210). Replace include_recipe 'git' with
git_client 'default' in the macOS recipe, matching the fix already
applied to the Linux recipe.
Signed-off-by: John McCrae <john.mccrae@progress.com>
* Correctiung a lint problem
Signed-off-by: John McCrae <john.mccrae@progress.com>
* fix(kitchen-tests): exclude openSUSE from nscd resource
nscd service fails to start on openSUSE Leap 15 in Dokken containers
with 'Job for nscd.service failed because the control process exited
with error code'. Add platform_family?('suse') to the exclusion guard
alongside the existing fedora, AL2023, and RHEL 10+ exclusions.
Signed-off-by: John McCrae <john.mccrae@progress.com>
---------
Signed-off-by: John McCrae <john.mccrae@progress.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
cinc-bot
pushed a commit
to cinc-project/chef
that referenced
this pull request
May 17, 2026
* fix(kitchen-tests): fix nscd exclusion for AL2023 and git workaround on Windows
- Add Amazon Linux 2023 to the nscd exclusion guard in linux.rb.
AL2023 uses platform_family 'amazon' (not 'rhel'), so the existing
RHEL >= 10 guard did not apply, causing nscd install failures since
the package is not available on AL2023.
Also removed the redundant platform?(almalinux/rocky/oracle) sub-condition
as platform_family?('rhel') already covers those platforms.
- Replace the fragile path-based git uninstall workaround and
include_recipe 'git' in windows.rb with chocolatey_package 'git'
(action :upgrade). The previous FIXME band-aid hard-coded install
paths that do not cover Windows 2025 runners and caused version
conflicts. Using chocolatey_package is idempotent, installs the
latest available git version, and avoids the downgrade issue.
- Update metadata.rb supports to include all platforms actually tested
in CI: almalinux, rocky, oracle, windows, freebsd, mac_os_x.
Signed-off-by: John McCrae <john.mccrae@progress.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
* fix(kitchen-tests): migrate to nscd v7 custom resource API
nscd cookbook v7.0.0 (released 2026-05-06) is a breaking change that
removed the default recipe in favour of custom resources (sous-chefs/nscd#61).
Policyfile was resolving the latest version, causing:
Chef::Exceptions::RecipeNotFound: could not find recipe default for cookbook nscd
Replace include_recipe 'nscd' with the new custom resource call and
restore the depends 'nscd' entry in metadata.rb that was accidentally
dropped in a prior commit.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
* fix(kitchen-tests): migrate to git v13 custom resource API
git cookbook v13.0.0 (released 2026-05-07) is a breaking change that
removed the default recipe in favour of custom resources (sous-chefs/git#210).
Policyfile was resolving the latest version, causing:
Chef::Exceptions::RecipeNotFound: could not find recipe default for cookbook git
Replace include_recipe 'git' with the new custom resource call git_client 'default'.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
* fix(kitchen-tests): migrate macos recipe to git v13 custom resource API
git cookbook v13.0.0 removed the default recipe in favour of custom
resources (sous-chefs/git#210). Replace include_recipe 'git' with
git_client 'default' in the macOS recipe, matching the fix already
applied to the Linux recipe.
Signed-off-by: John McCrae <john.mccrae@progress.com>
* Correctiung a lint problem
Signed-off-by: John McCrae <john.mccrae@progress.com>
* fix(kitchen-tests): exclude openSUSE from nscd resource
nscd service fails to start on openSUSE Leap 15 in Dokken containers
with 'Job for nscd.service failed because the control process exited
with error code'. Add platform_family?('suse') to the exclusion guard
alongside the existing fedora, AL2023, and RHEL 10+ exclusions.
Signed-off-by: John McCrae <john.mccrae@progress.com>
---------
Signed-off-by: John McCrae <john.mccrae@progress.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification