-
Notifications
You must be signed in to change notification settings - Fork 0
add favicon #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: base-sha/e3612e942f61ed40a43835734393e6965f7efaac
Are you sure you want to change the base?
add favicon #3
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -6,6 +6,10 @@ | |||||||||||||||||
| <meta name="viewport" content="width=device-width"> | ||||||||||||||||||
| <title>How to add a dictionary to Rushk</title> | ||||||||||||||||||
| <link href="https://xorol.github.io/style.css" rel="stylesheet" type="text/css" /> | ||||||||||||||||||
| <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png"> | ||||||||||||||||||
| <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"> | ||||||||||||||||||
| <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png"> | ||||||||||||||||||
| <link rel="manifest" href="/site.webmanifest"> | ||||||||||||||||||
|
Comment on lines
+9
to
+12
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
While adding favicons enhances brand visibility, review if it's necessary for all pages, especially if some are not frequently accessed directly.
Suggested change
|
||||||||||||||||||
| </head> | ||||||||||||||||||
|
|
||||||||||||||||||
| <body> | ||||||||||||||||||
|
|
||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2,6 +2,10 @@ | |||||||||||||||||||
| <head> | ||||||||||||||||||||
| <title>Rushk</title> | ||||||||||||||||||||
| <link href="style.css" type="text/css" rel="stylesheet"/> | ||||||||||||||||||||
| <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png"> | ||||||||||||||||||||
| <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"> | ||||||||||||||||||||
| <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png"> | ||||||||||||||||||||
| <link rel="manifest" href="/site.webmanifest"> | ||||||||||||||||||||
|
Comment on lines
+5
to
+8
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Ensure the server correctly serves the site.webmanifest file with the 'application/manifest+json' MIME type for optimal compatibility.
Suggested change
|
||||||||||||||||||||
| </head> | ||||||||||||||||||||
| <body> | ||||||||||||||||||||
| <div class="topnav"></div> | ||||||||||||||||||||
|
|
||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stylesheet link uses a relative path, while favicon links use root-relative paths. Consider aligning the path usage for consistency and maintainability.