Skip to content

Add default descriptions to every action#908

Merged
jviotti merged 1 commit into
mainfrom
action-descriptions
May 15, 2026
Merged

Add default descriptions to every action#908
jviotti merged 1 commit into
mainfrom
action-descriptions

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 15, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Re-trigger cubic

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 15, 2026

🤖 Augment PR Summary

Summary: This PR introduces a single source of truth for human-readable action descriptions and exposes them via the action dispatcher.

Changes:

  • Added a static constexpr std::string_view DESCRIPTION constant to each registered action class
  • Built a compile-time DESCRIPTIONS table in the dispatcher using the existing action enumeration macro
  • Added ActionDispatcher::description(context) to retrieve the description for a given action context
  • Added unit tests validating each description, ensuring every action has a non-empty description, and verifying out-of-range behavior

Technical Notes: Descriptions stay aligned with action types by reusing SOURCEMETA_ONE_FOR_EACH_ACTION, and the API returns an empty std::string_view for unknown contexts.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 5f05bd8 Previous: 11e4993 Ratio
Add one schema (0 existing) 242 ms 232 ms 1.04
Add one schema (100 existing) 25 ms 25 ms 1
Add one schema (1000 existing) 86 ms 78 ms 1.10
Add one schema (10000 existing) 721 ms 650 ms 1.11
Update one schema (1 existing) 18 ms 17 ms 1.06
Update one schema (101 existing) 26 ms 23 ms 1.13
Update one schema (1001 existing) 85 ms 75 ms 1.13
Update one schema (10001 existing) 726 ms 640 ms 1.13
Cached rebuild (1 existing) 5 ms 5 ms 1
Cached rebuild (101 existing) 8 ms 7 ms 1.14
Cached rebuild (1001 existing) 30 ms 26 ms 1.15
Cached rebuild (10001 existing) 284 ms 242 ms 1.17
Index 100 schemas 109 ms 111 ms 0.98
Index 1000 schemas 1008 ms 1051 ms 0.96
Index 10000 schemas 13650 ms 19231 ms 0.71

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 5f05bd8 Previous: 11e4993 Ratio
Add one schema (0 existing) 236 ms 233 ms 1.01
Add one schema (100 existing) 26 ms 29 ms 0.90
Add one schema (1000 existing) 80 ms 89 ms 0.90
Add one schema (10000 existing) 648 ms 717 ms 0.90
Update one schema (1 existing) 22 ms 22 ms 1
Update one schema (101 existing) 26 ms 29 ms 0.90
Update one schema (1001 existing) 84 ms 91 ms 0.92
Update one schema (10001 existing) 666 ms 725 ms 0.92
Cached rebuild (1 existing) 6 ms 7 ms 0.86
Cached rebuild (101 existing) 8 ms 12 ms 0.67
Cached rebuild (1001 existing) 29 ms 33 ms 0.88
Cached rebuild (10001 existing) 249 ms 283 ms 0.88
Index 100 schemas 116 ms 121 ms 0.96
Index 1000 schemas 1369 ms 1098 ms 1.25
Index 10000 schemas 16105 ms 14608 ms 1.10

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 17628b8 into main May 15, 2026
5 checks passed
@jviotti jviotti deleted the action-descriptions branch May 15, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant